Allow clicks to windows disabled by modal dialogs to bring the entire modal s...

chrome/views/window.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/views/window.h"
 
 #include <shellapi.h>
 
 #include "base/win_util.h"
 #include "chrome/app/chrome_dll_resource.h"
@@ skipping 771 matching lines @@
 
 LRESULT Window::OnNCUAHDrawFrame(UINT msg, WPARAM w_param,
                                             LPARAM l_param) {
   // See comment in widget_win.h at the definition of WM_NCUAHDRAWCAPTION for
   // an explanation about why we need to handle this message.
   SetMsgHandled(!non_client_view_->UseNativeFrame());
   return 0;
 }
 
 LRESULT Window::OnSetCursor(HWND window, UINT hittest_code, UINT message) {
+  // If the window is disabled, it's because we're showing a modal dialog box.
+  // We need to let DefWindowProc handle the message. That's because
+  // DefWindowProc for WM_SETCURSOR with message = some kind of mouse button
+  // down message sends the top level window a WM_ACTIVATEAPP message, which we
+  // otherwise wouldn't get. The symptom of not doing this is that if the user
+  // has a window in the background with a modal dialog open, they can't click
+  // on the disabled background window to bring the entire stack to the front.
+  // This is annoying because they then have to move all the foreground windows
+  // out of the way to be able to activate said window. I love how on Windows,
+  // the answer isn't always logical.
+  if (!IsWindowEnabled(GetHWND()))
+    return WidgetWin::OnSetCursor(window, hittest_code, message);
+
   int index = RC_NORMAL;
   switch (hittest_code) {
     case HTTOP:
     case HTBOTTOM:
       index = RC_VERTICAL;
       break;
     case HTTOPLEFT:
     case HTBOTTOMRIGHT:
       index = RC_NWSE;
       break;
@@ skipping 349 matching lines @@
     resize_cursors_[RC_VERTICAL] = LoadCursor(NULL, IDC_SIZENS);
     resize_cursors_[RC_HORIZONTAL] = LoadCursor(NULL, IDC_SIZEWE);
     resize_cursors_[RC_NESW] = LoadCursor(NULL, IDC_SIZENESW);
     resize_cursors_[RC_NWSE] = LoadCursor(NULL, IDC_SIZENWSE);
     initialized = true;
   }
 }
 
 }  // namespace views