Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6025)

Unified Diff: chrome/common/extensions/api/cast_channel.idl

Issue 393023003: Added connection timeout functionality to CastSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: JS API plumbing, switch approach from MessageLoop to Timer, better testing. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/cast_channel.idl
diff --git a/chrome/common/extensions/api/cast_channel.idl b/chrome/common/extensions/api/cast_channel.idl
index d034bf13790ecdd21526d68d184a7ad6ad5e58bf..0c745c754c4bc46fd77aa865f841608e82cab250 100644
--- a/chrome/common/extensions/api/cast_channel.idl
+++ b/chrome/common/extensions/api/cast_channel.idl
@@ -43,7 +43,9 @@ namespace cast.channel {
// An invalid channel id was passed.
invalid_channel_id,
// Unspecified error.
- unknown
+ unknown,
+ // The connection could not be established before timing out.
+ connect_timeout
mark a. foltz 2014/07/17 23:56:50 Can we leave "unknown" as the last enum value?
Kevin M 2014/07/22 18:51:49 Done. This a forward compatible change, right? Jav
mark a. foltz 2014/07/22 18:57:53 Enums are passed by string, e.g. 'connection_timeo
};
// Authentication methods that may be required to connect to a Cast receiver.
@@ -64,6 +66,11 @@ namespace cast.channel {
// The port number to connect to, 0-65535.
long port;
+ // The amount of time to wait in milliseconds before stopping the
+ // connection process. Timeouts are disabled if the value is zero.
+ // The default timeout is 5000ms/5 seconds.
+ long? timeout;
mark a. foltz 2014/07/17 23:56:50 Maybe just 5000 ms.
Kevin M 2014/07/22 18:51:49 OK. 8000ms to match cloudview.sender.ChannelServic
+
// The authentication method required for the channel.
ChannelAuthType auth;
};

Powered by Google App Engine
This is Rietveld 408576698