Added connection timeout functionality to CastSocket.

chrome/common/extensions/api/cast_channel.idl

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // API for communicating with a Google Cast device over an authenticated
 // channel.
 namespace cast.channel {
 
   // The state of the channel.
   enum ReadyState {
@@ skipping 25 matching lines @@
     // There was an error writing or reading from the underlying socket.
     socket_error,
     // A transport level occurred (like an unparseable message).
     transport_error,
     // The client attempted to send an unsupported message type through the
     // channel.
     invalid_message,
     // An invalid channel id was passed.
     invalid_channel_id,
     // Unspecified error.
-    unknown
+    unknown,
+    // The connection could not be established before timing out.
+    connect_timeout

[mark a. foltz, 2014/07/17 23:56:50]

Can we leave "unknown" as the last enum value?

[Kevin M, 2014/07/22 18:51:49]

Done. This a forward compatible change, right? Javascript understands enum
values by their identifiers, not ordinal values, right?

[mark a. foltz, 2014/07/22 18:57:53]

Enums are passed by string, e.g. 'connection_timeout', to/from the JS.

   };
 
   // Authentication methods that may be required to connect to a Cast receiver.
   enum ChannelAuthType {
     // SSL over TCP.
     ssl,
     // SSL over TCP with challenge and receiver signature verification.
     ssl_verified
   };
 
   // Describes the information needed to connect to a Cast receiver.
   // This replaces the prior use of cast:// and casts:// URLs.
   dictionary ConnectInfo {
     // The IPV4 address of the Cast receiver, e.g. '198.1.0.2'.
     // TODO(mfoltz): Investigate whether IPV6 addresses "just work."
     DOMString ipAddress;
 
     // The port number to connect to, 0-65535.
     long port;
 
+    // The amount of time to wait in milliseconds before stopping the
+    // connection process. Timeouts are disabled if the value is zero.
+    // The default timeout is 5000ms/5 seconds.
+    long? timeout;

[mark a. foltz, 2014/07/17 23:56:50]

Maybe just 5000 ms.

[Kevin M, 2014/07/22 18:51:49]

OK. 8000ms to match cloudview.sender.ChannelService.CHANNEL_CREATION_TIMEOUT_ .

+
     // The authentication method required for the channel.
     ChannelAuthType auth;
   };
 
   // Describes the state of a channel to a Cast receiver.
   dictionary ChannelInfo {
     // Id for the channel.
     long channelId;
 
     // DEPRECATED: The URL to the receiver.  This field will be removed in a
@@ skipping 77 matching lines @@
   interface Events {
     // Fired when a message is received on an open channel.
     static void onMessage(ChannelInfo channel,
                           MessageInfo message);
 
     // Fired when an error occurs as a result of a channel method or a network
     // event.
     static void onError(ChannelInfo channel);
   };
 };