Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 392883002: fix narrowing conversion warning in SpdyFramerTest.CreatePriority (Closed)

Created:
6 years, 5 months ago by Mostyn Bramley-Moore
Modified:
6 years, 5 months ago
Reviewers:
Johnny, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

fix narrowing conversion warning in SpdyFramerTest.CreatePriority Avoid narrowing conversion warnings by not trying to put a char in an unsigned char array. BUG=345769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/spdy/spdy_framer_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mostyn Bramley-Moore
@Johnny, Ryan: PTAL at this tiny fixup from one of the patches in https://codereview.chromium.org/358493002 ...
6 years, 5 months ago (2014-07-15 11:18:38 UTC) #1
Johnny
lgtm
6 years, 5 months ago (2014-07-15 18:02:06 UTC) #2
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 5 months ago (2014-07-15 20:01:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/392883002/1
6 years, 5 months ago (2014-07-15 20:02:39 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 05:15:56 UTC) #5
Message was sent while issue was closed.
Change committed as 283352

Powered by Google App Engine
This is Rietveld 408576698