Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 358493002: Land recent SPDY changes (through 70021377) (Closed)

Created:
6 years, 6 months ago by Johnny
Modified:
6 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Land recent SPDY changes (through 70021377) Stop using SpdySynReplyIR for SPDY 4. This lands server change 68038935 by hkhalil. Also update SpdyTestUtil fixture utilities to appropriately select SpdySynReplyIR vs SpdyHeadersIR. Update tests use of fixtures as needed. https://codereview.chromium.org/344253008/ SpdyFramerTests: Remove redundant .get() calls on unique_ptrs This lands server change 68111049 by rjshade. https://codereview.chromium.org/347063008/ Update net/spdy naming per style guideline with clang_tidy. This lands server change 68244989 by assar. https://codereview.chromium.org/355493003/ SPDY cleanup: use ParseFrameType and SerializeFrameType Instead of SpdyFrameType enum values. Also remove NOOP frames from the set of recognized frames. No functional change since NOOP frames are deprecated and not seen in the wild. This lands server change 68256336 by mlavan. https://codereview.chromium.org/354483005/ SpdyFramer dead code removal. This lands server change 68707873 by hkhalil. https://codereview.chromium.org/350713006/ SpdyFramer hooks for parsing and handling PRIORITY frames. This lands server change 68830313 by mlavan. https://codereview.chromium.org/353443005/ Stop using SpdySynStreamIR for SPDY 4. This lands server change 69298498 by hkhalil. Also update SpdyTestUtil fixture utilities to appropriately select SpdySynStreamIR vs SpdyHeadersIR. Update tests use of fixtures as needed. https://codereview.chromium.org/357513003/ Remove "Accept SETTINGS_COMPRESS_DATA frames for HTTP2." Per-frame gzip compression has been removed from the HTTP2 spec. This lands server change 69385195 by mlavan. https://codereview.chromium.org/350213004/ Implement HTTP/2 priority tree structure. This lands server change 69391145 by mlavan. https://codereview.chromium.org/352693003/ HPACK changes required for specification draft '08 * Update the Huffman code and test cases. * Updated static entry 16 to "accept-encoding": "gzip, deflate". * Update various section references in comments. This lands server change 69769491 by jgraettinger. https://codereview.chromium.org/352583006/ Treat HTTP2 priority weight as zero-indexed. For compatibility with wire format. This lands server change 69862681 by mlavan. https://codereview.chromium.org/337613010/ Remove padding from CONTINUATION frames They've been removed from the HTTP2 draft spec. This lands server change 69868302 by raullenchai. https://codereview.chromium.org/358483003/ Deprecate HTTP/2 PAD_HIGH field and enforce max padding size to 256 octets. 1. Replaced *_FLAG_PAD_LOW and *_FLAG_PAD_HIGH flags with *_FLAG_PADDED; 2. Reduce the size of pad length field from two octets to one octet (deprecated pad_high field); 3. Enforce the max padding size to be 256 octets. This lands server change 69870499 by raullenchai. https://codereview.chromium.org/349293010/ Update SPDY4 settings ID to 16 bits (from 8). This lands server change 70021377 by jgraettinger. https://codereview.chromium.org/352383002/ BUG=345769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280206

Patch Set 1 : Rebase. #

Patch Set 2 : Rebase on 16-bit settings ID. #

Patch Set 3 : Rebase on code-review-feedback updates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2178 lines, -1496 lines) Patch
M net/http/http_network_transaction_unittest.cc View 6 chunks +23 lines, -37 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 chunk +6 lines, -16 lines 0 comments Download
M net/net.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/hpack_constants.h View 2 chunks +10 lines, -10 lines 0 comments Download
M net/spdy/hpack_constants.cc View 1 chunk +256 lines, -256 lines 0 comments Download
M net/spdy/hpack_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_decoder_test.cc View 11 chunks +36 lines, -36 lines 0 comments Download
M net/spdy/hpack_encoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_entry.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/hpack_header_table.h View 4 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/hpack_header_table.cc View 1 chunk +61 lines, -61 lines 0 comments Download
M net/spdy/hpack_huffman_table_test.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M net/spdy/hpack_input_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_input_stream_test.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M net/spdy/hpack_output_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/hpack_string_util.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_frame_builder.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_framer.h View 3 chunks +10 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 33 chunks +131 lines, -196 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 75 chunks +296 lines, -356 lines 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 8 chunks +18 lines, -18 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 23 chunks +42 lines, -183 lines 0 comments Download
A net/spdy/spdy_priority_tree.h View 1 2 1 chunk +558 lines, -0 lines 0 comments Download
A net/spdy/spdy_priority_tree_test.cc View 1 chunk +399 lines, -0 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 2 11 chunks +47 lines, -31 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 2 8 chunks +40 lines, -15 lines 0 comments Download
M net/spdy/spdy_protocol_test.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 2 chunks +33 lines, -33 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +27 lines, -11 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 2 chunks +15 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 10 chunks +93 lines, -94 lines 0 comments Download
M net/spdy/spdy_websocket_test_util.cc View 3 chunks +9 lines, -64 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Johnny
6 years, 6 months ago (2014-06-25 18:29:29 UTC) #1
Ryan Hamilton
lgtm Woo hoo! I reached the end of the CLs :>
6 years, 6 months ago (2014-06-25 23:31:54 UTC) #2
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 6 months ago (2014-06-26 18:21:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/358493002/150001
6 years, 6 months ago (2014-06-26 18:26:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 19:48:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 21:04:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/32759)
6 years, 6 months ago (2014-06-26 21:04:54 UTC) #7
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 6 months ago (2014-06-26 23:51:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/358493002/150001
6 years, 6 months ago (2014-06-26 23:52:18 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 02:21:34 UTC) #10
Message was sent while issue was closed.
Change committed as 280206

Powered by Google App Engine
This is Rietveld 408576698