Issue 39271: Change JSONFileValueSerializer to use FilePath by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39271: Change JSONFileValueSerializer to use FilePath by default. (Closed)

Created:
11 years, 9 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change JSONFileValueSerializer to use FilePath by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11156

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/common/json_value_serializer.h	View		3 chunks	+7 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

LG http://codereview.chromium.org/39271/diff/1/2 File chrome/common/json_value_serializer.h (right): http://codereview.chromium.org/39271/diff/1/2#newcode97 Line 97: FilePath json_file_path_; there doesn't need to be ...

11 years, 9 months ago (2009-03-06 19:40:09 UTC) #2

Erik does not do reviews

11 years, 9 months ago (2009-03-06 19:42:14 UTC) #3

http://codereview.chromium.org/39271/diff/1/2
File chrome/common/json_value_serializer.h (right):

http://codereview.chromium.org/39271/diff/1/2#newcode97
Line 97: FilePath json_file_path_;
On 2009/03/06 19:40:10, Matt Perry wrote:
> there doesn't need to be a corresponding .cc change for this?

believe it or not, no.  The reason is that all of the file_util methods that
operate on paths all take FilePath objects.  If they take wstring, it's as a
decprecated method that just converts to FilePath.

Expand Messages | Collapse Messages