Change JSONFileValueSerializer to use FilePath by default.

chrome/common/json_value_serializer.h

Index: chrome/common/json_value_serializer.h
===================================================================
--- chrome/common/json_value_serializer.h	(revision 11116)
+++ chrome/common/json_value_serializer.h	(working copy)
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/file_path.h"
 #include "base/values.h"
 
 class JSONStringValueSerializer : public ValueSerializer {
@@ -66,8 +67,12 @@
   // deserialization or the destination of the serialization.
   // When deserializing, the file should exist, but when serializing, the
   // serializer will attempt to create the file at the specified location.
+  JSONFileValueSerializer(const FilePath& json_file_path)
+    : json_file_path_(json_file_path) {}
+  // DEPRECATED - DO NOT USE
+  // TODO(port): remove references to this
   JSONFileValueSerializer(const std::wstring& json_file_path)
-    : json_file_path_(json_file_path) {}
+    : json_file_path_(FilePath::FromWStringHack(json_file_path)) {}
 
   ~JSONFileValueSerializer() {}
 
@@ -89,7 +94,7 @@
   Value* Deserialize(std::string* error_message);
 
  private:
-  std::wstring json_file_path_;
+  FilePath json_file_path_;

[Matt Perry, 2009/03/06 19:40:10]

there doesn't need to be a corresponding .cc change for this?

[Erik does not do reviews, 2009/03/06 19:42:14]

believe it or not, no.  The reason is that all of the file_util methods that
operate on paths all take FilePath objects.  If they take wstring, it's as a
decprecated method that just converts to FilePath.

 
   DISALLOW_EVIL_CONSTRUCTORS(JSONFileValueSerializer);
 };