Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 392453002: Revert of Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (Closed)

Created:
6 years, 5 months ago by reed2
Modified:
6 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (https://codereview.chromium.org/382543005/) Reason for revert: found and fixed the asserts -- we were drawing with unpremul bitmaps, but our blits assumed they were premul. Fix was to detect this and just draw nothing. Original issue's description: > Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (https://codereview.chromium.org/388803007/) > > Reason for revert: > still failing (randomly?) bench sometimes. need stack dump to diagnose. > > Original issue's description: > > Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels > > usning it. > > > > Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)" > > > > This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce. > > > > TBR=scroggo@google.com > > > > Committed: https://skia.googlesource.com/skia/+/debba5c3d091159149f8a88ab5dcd44dd72e0dc7 > > TBR=reed@google.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/651eaeadeb0b1407f5fe192aeda90db1680fa2b8 TBR=reed@google.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -149 lines) Patch
M include/core/SkBitmap.h View 1 chunk +22 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +14 lines, -13 lines 0 comments Download
M src/core/SkBitmap.cpp View 3 chunks +76 lines, -61 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 3 chunks +2 lines, -74 lines 0 comments Download
M src/core/SkConfig8888.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkConfig8888.cpp View 2 chunks +142 lines, -0 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 2 chunks +94 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
6 years, 5 months ago (2014-07-13 10:59:35 UTC) #1
reed2
The CQ bit was unchecked by reed@chromium.org
6 years, 5 months ago (2014-07-13 10:59:57 UTC) #2
reed2
The CQ bit was checked by reed@chromium.org
6 years, 5 months ago (2014-07-13 11:00:30 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-13 11:01:11 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698