runtime/vm/stub_code_mips.cc - Issue 392343002: Cleanup of class id loading sequences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_mips.cc

Issue 392343002: Cleanup of class id loading sequences. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_mips.cc

===================================================================

--- runtime/vm/stub_code_mips.cc (revision 38283)

+++ runtime/vm/stub_code_mips.cc (working copy)

@@ -1432,8 +1432,8 @@

__ subu(T1, T1, TMP);

__ sll(T3, T1, 1); // T1 (argument_count - 1) is smi.

__ addu(T3, T3, SP);

- __ lw(T3, Address(T3));

- __ LoadTaggedClassIdMayBeSmi(T3, T3);

+ __ lw(T4, Address(T3));

+ __ LoadTaggedClassIdMayBeSmi(T3, T4);

// T1: argument_count - 1 (smi).

// T3: receiver's class ID (smi).

@@ -1448,8 +1448,8 @@

__ addu(T3, T1, T3);

__ sll(T3, T3, 1);

__ addu(T3, SP, T3);

- __ lw(T3, Address(T3));

- __ LoadTaggedClassIdMayBeSmi(T3, T3);

+ __ lw(T4, Address(T3));

+ __ LoadTaggedClassIdMayBeSmi(T3, T4);

// T3: next argument class ID (smi).

__ lw(T4, Address(T0, i * kWordSize));

// T4: next class ID to check (smi).

@@ -1470,8 +1470,8 @@

if (num_args > 1) {

__ sll(T3, T1, 1);

__ addu(T3, T3, SP);

- __ lw(T3, Address(T3));

- __ LoadTaggedClassIdMayBeSmi(T3, T3);

+ __ lw(T4, Address(T3));

+ __ LoadTaggedClassIdMayBeSmi(T3, T4);

}

const intptr_t entry_size = ICData::TestEntryLengthFor(num_args) * kWordSize;