Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 392323002: Calculate the correct target platform for Android. (Closed)

Created:
6 years, 5 months ago by aberent
Modified:
6 years, 5 months ago
Reviewers:
prasadv, qyearsley
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Calculate the correct target platform for Android. The android-chrome-shell browser is an upstream browser, so should be using a target platform of 'android' not 'android-chrome'. BUG=394324 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/run-bisect-perf-regression.py View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
aberent
6 years, 5 months ago (2014-07-16 15:41:02 UTC) #1
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 5 months ago (2014-07-16 16:21:09 UTC) #2
prasadv
The CQ bit was unchecked by prasadv@chromium.org
6 years, 5 months ago (2014-07-16 16:21:13 UTC) #3
prasadv
lgtm
6 years, 5 months ago (2014-07-16 16:21:21 UTC) #4
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 5 months ago (2014-07-16 16:21:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/392323002/1
6 years, 5 months ago (2014-07-16 16:24:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 18:15:18 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 19:00:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171666)
6 years, 5 months ago (2014-07-16 19:00:12 UTC) #9
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 5 months ago (2014-07-16 22:46:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/392323002/1
6 years, 5 months ago (2014-07-16 22:50:03 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 23:16:36 UTC) #12
Message was sent while issue was closed.
Change committed as 283567

Powered by Google App Engine
This is Rietveld 408576698