Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 392323002: Calculate the correct target platform for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index c2f9196e457a562fa78db8f36c128079df05ab05..104b20c659148f2d2e757c51545d0849ef925bdd 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -182,6 +182,7 @@ def _OutputFailedResults(text_to_print):
def _CreateBisectOptionsFromConfig(config):
+ print config['command']
opts_dict = {}
opts_dict['command'] = config['command']
opts_dict['metric'] = config['metric']
@@ -213,7 +214,9 @@ def _CreateBisectOptionsFromConfig(config):
raise RuntimeError('Cros build selected, but BISECT_CROS_IP or'
'BISECT_CROS_BOARD undefined.')
elif 'android' in config['command']:
- if 'android-chrome' in config['command']:
+ if 'android-chrome-shell' in config['command']:
+ opts_dict['target_platform'] = 'android'
+ elif 'android-chrome' in config['command']:
opts_dict['target_platform'] = 'android-chrome'
else:
opts_dict['target_platform'] = 'android'
@@ -390,7 +393,9 @@ def _RunBisectionScript(config, working_directory, path_to_file, path_to_goma,
return 1
if 'android' in config['command']:
- if 'android-chrome' in config['command']:
+ if 'android-chrome-shell' in config['command']:
+ cmd.extend(['--target_platform', 'android'])
+ elif 'android-chrome' in config['command']:
cmd.extend(['--target_platform', 'android-chrome'])
else:
cmd.extend(['--target_platform', 'android'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698