TimingFunction test helper.

Source/core/platform/animation/TimingFunction.h

Index: Source/core/platform/animation/TimingFunction.h
diff --git a/Source/core/platform/animation/TimingFunction.h b/Source/core/platform/animation/TimingFunction.h
index 342925772719f6112f7767545cc02fe44402e40d..cc9db512250d142bee9dc3ac1c9370bed1915aef 100644
--- a/Source/core/platform/animation/TimingFunction.h
+++ b/Source/core/platform/animation/TimingFunction.h
@@ -34,6 +34,8 @@
 #include "wtf/RefCounted.h"
 #include "wtf/Vector.h"
 #include <algorithm>
+#include <iosfwd>
+
 
 namespace WebCore {
 
@@ -311,6 +313,10 @@ private:
         double m_min;
         double m_max;
         RefPtr<TimingFunction> m_timingFunction;
+
+        // Allow printing of our segments. Can be removed once
+        // ChainedTimingFunction has a public API for segments.
+        friend void PrintTo(const ChainedTimingFunction&, ::std::ostream*, bool);

[shans, 2013/10/31 20:22:54]

I think it would be cleaner to put these methods on a
CoreAnimationTimingFunctionTest object and just friend that here (or
alternatively, if the TimingFunctionTestHelper is intended for use outside
TimingFunctionTest, then on a TimingFunctionTestHelper object). 

That way we don't mix up the definition of TimingFunction with testing API, and
we don't need to include testing-specific includes here (like <iosfwd>).

[mithro-old, 2013/11/03 09:58:24]

The way PrintTo methods are defined is not controlled by myself. It is
controlled via gtest.

I could create a TimingFunctionTestHelper object which I can friend and then
PrintTo methods call that? Will give that a try on Monday morning.

     };
 
     ChainedTimingFunction()
@@ -320,6 +326,10 @@ private:
     }
 
     Vector<Segment> m_segments;
+
+    // Allow printing of our segments. Can be removed once
+    // ChainedTimingFunction has a public API for segments.
+    friend void PrintTo(const ChainedTimingFunction&, ::std::ostream*, bool);
 };
 
 } // namespace WebCore