TimingFunction test helper.

Source/core/platform/animation/TimingFunction.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 16 matching lines @@
 
 #include "RuntimeEnabledFeatures.h"
 #include "platform/animation/AnimationUtilities.h" // For blend()
 #include "platform/animation/UnitBezier.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/Vector.h"
 #include <algorithm>
+#include <iosfwd>
+
 
 namespace WebCore {
 
 class TimingFunction : public RefCounted<TimingFunction> {
 public:
 
     enum Type {
         LinearFunction, CubicBezierFunction, StepsFunction, ChainedFunction
     };
 
@@ skipping 257 matching lines @@
             return scaleFromLocal(m_timingFunction->evaluate(scaleToLocal(fraction), accuracy));
         }
 
     private:
         double scaleToLocal(double x) const { return (x - m_min) / (m_max - m_min); }
         double scaleFromLocal(double x) const { return blend(m_min, m_max, x); }
 
         double m_min;
         double m_max;
         RefPtr<TimingFunction> m_timingFunction;
+
+        // Allow printing of our segments. Can be removed once
+        // ChainedTimingFunction has a public API for segments.
+        friend void PrintTo(const ChainedTimingFunction&, ::std::ostream*, bool);

[shans, 2013/10/31 20:22:54]

I think it would be cleaner to put these methods on a
CoreAnimationTimingFunctionTest object and just friend that here (or
alternatively, if the TimingFunctionTestHelper is intended for use outside
TimingFunctionTest, then on a TimingFunctionTestHelper object). 

That way we don't mix up the definition of TimingFunction with testing API, and
we don't need to include testing-specific includes here (like <iosfwd>).

[mithro-old, 2013/11/03 09:58:24]

The way PrintTo methods are defined is not controlled by myself. It is
controlled via gtest.

I could create a TimingFunctionTestHelper object which I can friend and then
PrintTo methods call that? Will give that a try on Monday morning.

     };
 
     ChainedTimingFunction()
         : TimingFunction(ChainedFunction)
     {
         ASSERT(RuntimeEnabledFeatures::webAnimationsEnabled());
     }
 
     Vector<Segment> m_segments;
+
+    // Allow printing of our segments. Can be removed once
+    // ChainedTimingFunction has a public API for segments.
+    friend void PrintTo(const ChainedTimingFunction&, ::std::ostream*, bool);
 };
 
 } // namespace WebCore
 
 #endif // TimingFunction_h