Chromium Code Reviews

Issue 39223002: TimingFunction test helper. (Closed)

Created:
7 years, 2 months ago by mithro-old
Modified:
7 years, 1 month ago
Reviewers:
dstockwell, shans, Steve Block
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

TimingFunction test helper. Makes it easier to use TimingFunction's in your tests as they can now be pretty printed. (They already had an operator==.) BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161306

Patch Set 1 #

Patch Set 2 : Rebasing onto master. #

Patch Set 3 : Restore the RuntimeEnabledFeatures::setWebAnimationsEnabled flag. #

Patch Set 4 : Moving test helper code into cpp file to fix linking issue. #

Total comments: 9

Patch Set 5 : Code review fixes. #

Total comments: 12

Patch Set 6 : CL fixes. #

Patch Set 7 : Using more permission regex for windows. #

Unified diffs Side-by-side diffs Stats (+325 lines, -16 lines)
M Source/core/core.gypi View 1 chunk +3 lines, -0 lines 0 comments
M Source/core/platform/animation/TimingFunction.h View 4 chunks +13 lines, -0 lines 0 comments
A + Source/core/platform/animation/TimingFunctionTestHelper.h View 2 chunks +15 lines, -16 lines 0 comments
A Source/core/platform/animation/TimingFunctionTestHelper.cpp View 1 chunk +150 lines, -0 lines 0 comments
A Source/core/platform/animation/TimingFunctionTestHelperTest.cpp View 1 chunk +144 lines, -0 lines 0 comments

Messages

Total messages: 12 (0 generated)
mithro-old
Hey guys, TimingFunctions are used quite a bit in our animation stuff, specially in the ...
7 years, 1 month ago (2013-10-31 12:16:45 UTC) #1
shans
https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunction.h File Source/core/platform/animation/TimingFunction.h (right): https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunction.h#newcode319 Source/core/platform/animation/TimingFunction.h:319: friend void PrintTo(const ChainedTimingFunction&, ::std::ostream*, bool); I think it ...
7 years, 1 month ago (2013-10-31 20:22:54 UTC) #2
mithro-old
The code in TimingFunctionTestHelper (the PrintTo) is shared by any test which uses a TimingFunction ...
7 years, 1 month ago (2013-11-01 00:42:14 UTC) #3
Steve Block
https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunctionTestHelper.cpp File Source/core/platform/animation/TimingFunctionTestHelper.cpp (right): https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunctionTestHelper.cpp#newcode116 Source/core/platform/animation/TimingFunctionTestHelper.cpp:116: ASSERT(!recursiveGuard); I don't really like the idea of adding ...
7 years, 1 month ago (2013-11-03 09:18:31 UTC) #4
mithro-old
https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunction.h File Source/core/platform/animation/TimingFunction.h (right): https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunction.h#newcode319 Source/core/platform/animation/TimingFunction.h:319: friend void PrintTo(const ChainedTimingFunction&, ::std::ostream*, bool); On 2013/10/31 20:22:54, ...
7 years, 1 month ago (2013-11-03 09:58:24 UTC) #5
shans
I think if we can't get the <iosfwd> include and PrintTo method defines out of ...
7 years, 1 month ago (2013-11-03 23:26:21 UTC) #6
Steve Block
https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunctionTestHelper.cpp File Source/core/platform/animation/TimingFunctionTestHelper.cpp (right): https://codereview.chromium.org/39223002/diff/200001/Source/core/platform/animation/TimingFunctionTestHelper.cpp#newcode116 Source/core/platform/animation/TimingFunctionTestHelper.cpp:116: ASSERT(!recursiveGuard); > Not sure what you mean by an ...
7 years, 1 month ago (2013-11-03 23:29:44 UTC) #7
mithro-old
On 2013/11/03 23:26:21, shans wrote: > I think if we can't get the <iosfwd> include ...
7 years, 1 month ago (2013-11-04 00:58:57 UTC) #8
Steve Block
lgtm https://codereview.chromium.org/39223002/diff/330001/Source/core/platform/animation/TimingFunction.h File Source/core/platform/animation/TimingFunction.h (right): https://codereview.chromium.org/39223002/diff/330001/Source/core/platform/animation/TimingFunction.h#newcode96 Source/core/platform/animation/TimingFunction.h:96: // Forward declare so we can friend it ...
7 years, 1 month ago (2013-11-04 23:05:02 UTC) #9
mithro-old
https://codereview.chromium.org/39223002/diff/330001/Source/core/platform/animation/TimingFunction.h File Source/core/platform/animation/TimingFunction.h (right): https://codereview.chromium.org/39223002/diff/330001/Source/core/platform/animation/TimingFunction.h#newcode96 Source/core/platform/animation/TimingFunction.h:96: // Forward declare so we can friend it below. ...
7 years, 1 month ago (2013-11-05 01:53:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/39223002/490001
7 years, 1 month ago (2013-11-05 04:12:26 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 06:09:08 UTC) #12
Message was sent while issue was closed.
Change committed as 161306

Powered by Google App Engine