Issue 392005: NTP: Hide "Make this my home page" after setting the home page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 392005: NTP: Hide "Make this my home page" after setting the home page.... (Closed)

Created:
11 years, 1 month ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
kuchhal, rahulk

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

NTP: Hide "Make this my home page" after setting the home page. This also fixes an l10n issue where the string was hard coded in English. Instead of using the tips infrastructure, after setting the home page we send an ack to the NTP and show a notification. In this way the user will see the notification even if they have hidden the tips. Added a ui test that clicks on the link and checks the state of the UI afterwards. BUG=25101 TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click on the link "Make this my home page" at the bottom. You should see a banner at the top. Pressing Alt-Home should now go to the NTP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31823

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -29 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View		2 chunks	+19 lines, -21 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui_uitest.cc	View	1 2	2 chunks	+71 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View		2 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Issue 392005: NTP: Hide "Make this my home page" after setting the home page.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages