NTP: Hide "Make this my home page" after setting the home page....

chrome/browser/dom_ui/new_tab_ui.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "chrome/browser/dom_ui/new_tab_ui.h"
 
 #include <set>
 
@@ skipping 458 matching lines @@
         list_member->GetType() == Value::TYPE_STRING) {
       std::string event_name;
       if (list_member->GetAsString(&event_name)) {
         dom_ui_->tab_contents()->LogNewTabTime(event_name);
       }
     }
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
-// NewTabPageSetHomepageHandler
+// NewTabPageSetHomePageHandler
 
-// Sets the new tab page as homepage when user clicks on "make this my homepage"
-// link.
-class NewTabPageSetHomepageHandler : public DOMMessageHandler {
+// Sets the new tab page as home page when user clicks on "make this my home
+// page" link.
+class NewTabPageSetHomePageHandler : public DOMMessageHandler {
  public:
-  NewTabPageSetHomepageHandler() {}
-  virtual ~NewTabPageSetHomepageHandler() {}
+  NewTabPageSetHomePageHandler() {}
+  virtual ~NewTabPageSetHomePageHandler() {}
 
   // DOMMessageHandler implementation.
   virtual void RegisterMessages();
 
-  // Callback for "SetHomepageLinkClicked".
-  void HandleSetHomepageLinkClicked(const Value* value);
+  // Callback for "setHomePage".
+  void HandleSetHomePage(const Value* value);
 
  private:
 
-  DISALLOW_COPY_AND_ASSIGN(NewTabPageSetHomepageHandler);
+  DISALLOW_COPY_AND_ASSIGN(NewTabPageSetHomePageHandler);
 };
 
-void NewTabPageSetHomepageHandler::RegisterMessages() {
-  dom_ui_->RegisterMessageCallback("SetHomepageLinkClicked", NewCallback(
-      this, &NewTabPageSetHomepageHandler::HandleSetHomepageLinkClicked));
+void NewTabPageSetHomePageHandler::RegisterMessages() {
+  dom_ui_->RegisterMessageCallback("setHomePage", NewCallback(
+      this, &NewTabPageSetHomePageHandler::HandleSetHomePage));
 }
 
-void NewTabPageSetHomepageHandler::HandleSetHomepageLinkClicked(
+void NewTabPageSetHomePageHandler::HandleSetHomePage(
     const Value* value) {
   dom_ui_->GetProfile()->GetPrefs()->SetBoolean(prefs::kHomePageIsNewTabPage,
                                                 true);
-  // TODO(rahulk): Show some kind of notification that new tab page has been
-  // set as homepage. This tip only shows up for a brief moment and disappears
-  // when new tab page gets refreshed.
   ListValue list_value;
-  DictionaryValue* tip_dict = new DictionaryValue();
-  tip_dict->SetString(L"tip_html_text", L"Welcome to your home page!");
-  list_value.Append(tip_dict);
-  dom_ui_->CallJavascriptFunction(L"tips", list_value);
+  list_value.Append(new StringValue(
+      l10n_util::GetString(IDS_NEW_TAB_HOME_PAGE_SET_NOTIFICATION)));
+  list_value.Append(new StringValue(
+      l10n_util::GetString(IDS_NEW_TAB_HOME_PAGE_HIDE_NOTIFICATION)));
+  dom_ui_->CallJavascriptFunction(L"onHomePageSet", list_value);
 }
 
 }  // namespace
 
 ///////////////////////////////////////////////////////////////////////////////
 // NewTabUI
 
 NewTabUI::NewTabUI(TabContents* contents)
     : DOMUI(contents),
       motd_message_id_(0),
@@ skipping 39 matching lines @@
     AddMessageHandler((new MetricsHandler())->Attach(this));
     if (WebResourcesEnabled())
       AddMessageHandler((new TipsHandler())->Attach(this));
 
 #if !defined(OS_POSIX)
     if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableSync)) {
       AddMessageHandler((new NewTabPageSyncHandler())->Attach(this));
     }
 #endif
 
-    AddMessageHandler((new NewTabPageSetHomepageHandler())->Attach(this));
+    AddMessageHandler((new NewTabPageSetHomePageHandler())->Attach(this));
 
     NewTabHTMLSource* html_source = new NewTabHTMLSource(GetProfile());
     bool posted = ChromeThread::PostTask(
         ChromeThread::IO, FROM_HERE,
         NewRunnableMethod(
             Singleton<ChromeURLDataManager>::get(),
             &ChromeURLDataManager::AddDataSource,
             html_source));
     if (!posted) {
       html_source->AddRef();
@@ skipping 366 matching lines @@
     full_html_.append(json_html);
     size_t after_offset = pos + template_data_placeholder.size();
     full_html_.append(new_tab_html.data() + after_offset,
                       new_tab_html.size() - after_offset);
   } else {
     NOTREACHED();
     full_html_.assign(new_tab_html.data(), new_tab_html.size());
   }
   jstemplate_builder::AppendI18nTemplateProcessHtml(&full_html_);
 }