Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.cc

Issue 391923006: Extra parameter to pass sub-message direction for validation message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added new function setValidationMessageDirection, to avoid replicate code in web_test_proxy Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/web_test_proxy.cc
diff --git a/content/shell/renderer/test_runner/web_test_proxy.cc b/content/shell/renderer/test_runner/web_test_proxy.cc
index 18086de32ee8f1eb6b975bb02ad542c083b682a3..666337743491cfe07d6a0ba6b33ced2b3b895625 100644
--- a/content/shell/renderer/test_runner/web_test_proxy.cc
+++ b/content/shell/renderer/test_runner/web_test_proxy.cc
@@ -9,8 +9,10 @@
#include "base/callback_helpers.h"
#include "base/command_line.h"
#include "base/debug/trace_event.h"
+#include "base/i18n/rtl.h"
#include "base/logging.h"
#include "base/strings/stringprintf.h"
+#include "base/strings/utf_string_conversions.h"
#include "content/public/common/content_switches.h"
#include "content/shell/renderer/test_runner/TestPlugin.h"
#include "content/shell/renderer/test_runner/WebTestDelegate.h"
@@ -378,14 +380,13 @@ bool WebTestProxyBase::RunFileChooser(
}
void WebTestProxyBase::ShowValidationMessage(
- const blink::WebRect& anchor_in_root_view,
- const blink::WebString& message,
- const blink::WebString& sub_message,
- blink::WebTextDirection hint) {
+ const base::string16& message,
+ const base::string16& sub_message) {
delegate_->printMessage(
- std::string("ValidationMessageClient: main-message=") +
- std::string(message.utf8()) + " sub-message=" +
- std::string(sub_message.utf8()) + "\n");
+ "ValidationMessageClient: main-message=" +
+ base::UTF16ToUTF8(message) +
+ " sub-message=" +
+ base::UTF16ToUTF8(sub_message) + "\n");
}
std::string WebTestProxyBase::CaptureTree(bool debug_render_tree) {
« content/renderer/render_view_impl.h ('K') | « content/shell/renderer/test_runner/web_test_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698