Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Unified Diff: content/renderer/render_view_impl.h

Issue 391923006: Extra parameter to pass sub-message direction for validation message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added new function setValidationMessageDirection, to avoid replicate code in web_test_proxy Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index a766328a9e53d929d51bb210e7337032888b4123..d1894cbed5b59eb2beda00a800e54ff3811488e4 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -383,8 +383,13 @@ class CONTENT_EXPORT RenderViewImpl
virtual bool runFileChooser(
const blink::WebFileChooserParams& params,
blink::WebFileChooserCompletion* chooser_completion);
+ void setValidationMessageDirection(base::string16& main_text,
jamesr 2014/09/02 19:14:56 this is a chromium-style function so it should hav
Habib Virji 2014/09/03 10:16:54 Done.
+ blink::WebTextDirection main_text_hint,
jamesr 2014/09/02 19:14:56 alignment is off
Habib Virji 2014/09/03 10:16:53 Done.
+ base::string16& sub_text,
jamesr 2014/09/02 19:14:56 we don't use non-const refs in chromium code. http
Habib Virji 2014/09/03 10:16:54 Done.
+ blink::WebTextDirection sub_text_hint);
virtual void showValidationMessage(const blink::WebRect& anchor_in_root_view,
const blink::WebString& main_text,
+ blink::WebTextDirection main_text_hint,
const blink::WebString& sub_text,
blink::WebTextDirection hint) OVERRIDE;
virtual void hideValidationMessage() OVERRIDE;
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698