Extra parameter to pass sub-message direction for validation message

content/renderer/render_view_impl.h

Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index a766328a9e53d929d51bb210e7337032888b4123..d1894cbed5b59eb2beda00a800e54ff3811488e4 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -383,8 +383,13 @@ class CONTENT_EXPORT RenderViewImpl
   virtual bool runFileChooser(
       const blink::WebFileChooserParams& params,
       blink::WebFileChooserCompletion* chooser_completion);
+  void setValidationMessageDirection(base::string16& main_text,

[jamesr, 2014/09/02 19:14:56]

this is a chromium-style function so it should have an uppercase first letter

[Habib Virji, 2014/09/03 10:16:54]

Done.

+                             blink::WebTextDirection main_text_hint,

[jamesr, 2014/09/02 19:14:56]

alignment is off

[Habib Virji, 2014/09/03 10:16:53]

Done.

+                             base::string16& sub_text,

[jamesr, 2014/09/02 19:14:56]

we don't use non-const refs in chromium code.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Reference_Argu....
 If you want to modify the parameter pass it by pointer, if you don't pass it by
const ref

[Habib Virji, 2014/09/03 10:16:54]

Done.

+                             blink::WebTextDirection sub_text_hint);
   virtual void showValidationMessage(const blink::WebRect& anchor_in_root_view,
                                      const blink::WebString& main_text,
+                                     blink::WebTextDirection main_text_hint,
                                      const blink::WebString& sub_text,
                                      blink::WebTextDirection hint) OVERRIDE;
   virtual void hideValidationMessage() OVERRIDE;