Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 391753002: Revert of [DevTools] Device mode: reset page scale when enabling and improve UI. (Closed)

Created:
6 years, 5 months ago by Justin Novosad
Modified:
6 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of [DevTools] Device mode: reset page scale when enabling and improve UI. (https://codereview.chromium.org/389573002/) Reason for revert: Speculative revert. A long list of compositing related layout tests began failing on the Mac Retina bot. Some of the tests look like they could just be rebaselined, others are true regressions and seem related to page scale. Regression range is 178044:178046 This is the only change in that range that is even remotely related to graphics. Original issue's description: > [DevTools] Device mode: reset page scale when enabling and improve UI. > > BUG=384563 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178045 TBR=pfeldman@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=384563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M Source/devtools/front_end/sdk/OverridesSupport.js View 5 chunks +3 lines, -7 lines 0 comments Download
M Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Novosad
Created Revert of [DevTools] Device mode: reset page scale when enabling and improve UI.
6 years, 5 months ago (2014-07-14 14:21:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/391753002/1
6 years, 5 months ago (2014-07-14 14:21:55 UTC) #2
commit-bot: I haz the power
Change committed as 178058
6 years, 5 months ago (2014-07-14 14:22:23 UTC) #3
Justin Novosad
6 years, 5 months ago (2014-07-14 15:23:22 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/387373004/ by junov@chromium.org.

The reason for reverting is: Speculative revert did not fix failures.

Powered by Google App Engine
This is Rietveld 408576698