Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 389573002: [DevTools] Device mode: reset page scale when enabling and improve UI. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Device mode: reset page scale when enabling and improve UI. BUG=384563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178045

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 5 chunks +7 lines, -3 lines 0 comments Download
M Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-11 09:19:46 UTC) #1
pfeldman
lgtm w/ nit https://codereview.chromium.org/389573002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/389573002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode280 Source/devtools/front_end/sdk/OverridesSupport.js:280: PageAgent.resetScrollAndPageScaleFactor(); You should use the target's ...
6 years, 5 months ago (2014-07-11 15:15:55 UTC) #2
dgozman
https://codereview.chromium.org/389573002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/389573002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode280 Source/devtools/front_end/sdk/OverridesSupport.js:280: PageAgent.resetScrollAndPageScaleFactor(); On 2014/07/11 15:15:55, pfeldman wrote: > You should ...
6 years, 5 months ago (2014-07-14 10:30:04 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-14 10:30:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/389573002/20001
6 years, 5 months ago (2014-07-14 10:30:38 UTC) #5
commit-bot: I haz the power
Change committed as 178045
6 years, 5 months ago (2014-07-14 11:30:05 UTC) #6
Justin Novosad
6 years, 5 months ago (2014-07-14 14:21:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/391753002/ by junov@chromium.org.

The reason for reverting is: Speculative revert. A long list of compositing
related layout tests began failing on the Mac Retina bot.  Some of the tests
look like they could just be rebaselined, others are true regressions and seem
related to page scale. Regression range is 178044:178046 This is the only change
in that range that is even remotely related to graphics..

Powered by Google App Engine
This is Rietveld 408576698