Implement ConstraintNotSatisfiedError for getusermedia

content/renderer/media/media_stream_impl_unittest.cc

Index: content/renderer/media/media_stream_impl_unittest.cc
diff --git a/content/renderer/media/media_stream_impl_unittest.cc b/content/renderer/media/media_stream_impl_unittest.cc
index 997340a0b6278371e984229d91a55166ea1fbfe1..216e41c429831b210596428dc82e6b765b7516ec 100644
--- a/content/renderer/media/media_stream_impl_unittest.cc
+++ b/content/renderer/media/media_stream_impl_unittest.cc
@@ -50,6 +50,7 @@ class MediaStreamImplUnderTest : public MediaStreamImpl {
             NULL, dependency_factory, media_stream_dispatcher.Pass()),
         state_(REQUEST_NOT_STARTED),
         result_(NUM_MEDIA_REQUEST_RESULTS),
+        result_name_(""),
         factory_(dependency_factory),
         video_source_(NULL) {
   }
@@ -81,6 +82,16 @@ class MediaStreamImplUnderTest : public MediaStreamImpl {
     result_ = result;
   }
 
+  virtual void GetUserMediaRequestFailed(
+      blink::WebUserMediaRequest* request_info,
+      MediaStreamRequestResult result,
+      const blink::WebString& result_name) OVERRIDE {
+    last_generated_stream_.reset();
+    state_ = REQUEST_FAILED;
+    result_ = result;
+    result_name_ = result_name;

[miu, 2014/07/30 19:37:23]

This is good, but where are the unit tests that check the value of
|result_name_| (and the code path that has to execute to reach this point)?

[jiajia.qin, 2014/07/31 13:43:00]

TEST_F(MediaStreamImplTest, MediaVideoSourceFailToStart) will reach this point.
But it's only for TrackStartError. So the result_name will be set empty string.

[miu, 2014/07/31 19:30:09]

So, you can copy-and-paste that test, and modify it a little so the result will
be MEDIA_DEVICE_CONSTRAINT_NOT_SATISFIED with a non-empty string, right?  ;-)

[jiajia.qin, 2014/08/01 05:25:33]

Done.

+  }
+
   virtual void EnumerateDevicesSucceded(
       blink::WebMediaDevicesRequest* request,
       blink::WebVector<blink::WebMediaDeviceInfo>& devices) OVERRIDE {
@@ -120,6 +131,7 @@ class MediaStreamImplUnderTest : public MediaStreamImpl {
   blink::WebMediaStream last_generated_stream_;
   RequestState state_;
   content::MediaStreamRequestResult result_;
+  blink::WebString result_name_;
   blink::WebVector<blink::WebMediaDeviceInfo> last_devices_;
   PeerConnectionDependencyFactory* factory_;
   MockMediaStreamVideoCapturerSource* video_source_;