Implement ConstraintNotSatisfiedError for getusermedia

content/renderer/media/media_stream_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/child/child_process.h"
 #include "content/renderer/media/media_stream.h"
 #include "content/renderer/media/media_stream_impl.h"
@@ skipping 32 matching lines @@
     REQUEST_FAILED,
   };
 
   MediaStreamImplUnderTest(
       PeerConnectionDependencyFactory* dependency_factory,
       scoped_ptr<MediaStreamDispatcher> media_stream_dispatcher)
       : MediaStreamImpl(
             NULL, dependency_factory, media_stream_dispatcher.Pass()),
         state_(REQUEST_NOT_STARTED),
         result_(NUM_MEDIA_REQUEST_RESULTS),
+        result_name_(""),
         factory_(dependency_factory),
         video_source_(NULL) {
   }
 
   void RequestUserMedia() {
     blink::WebUserMediaRequest user_media_request;
     state_ = REQUEST_NOT_COMPLETE;
     requestUserMedia(user_media_request);
   }
 
@@ skipping 11 matching lines @@
   }
 
   virtual void GetUserMediaRequestFailed(
       blink::WebUserMediaRequest* request_info,
       content::MediaStreamRequestResult result) OVERRIDE {
     last_generated_stream_.reset();
     state_ = REQUEST_FAILED;
     result_ = result;
   }
 
+  virtual void GetUserMediaRequestFailed(
+      blink::WebUserMediaRequest* request_info,
+      MediaStreamRequestResult result,
+      const blink::WebString& result_name) OVERRIDE {
+    last_generated_stream_.reset();
+    state_ = REQUEST_FAILED;
+    result_ = result;
+    result_name_ = result_name;

[miu, 2014/07/30 19:37:23]

This is good, but where are the unit tests that check the value of
|result_name_| (and the code path that has to execute to reach this point)?

[jiajia.qin, 2014/07/31 13:43:00]

TEST_F(MediaStreamImplTest, MediaVideoSourceFailToStart) will reach this point.
But it's only for TrackStartError. So the result_name will be set empty string.

[miu, 2014/07/31 19:30:09]

So, you can copy-and-paste that test, and modify it a little so the result will
be MEDIA_DEVICE_CONSTRAINT_NOT_SATISFIED with a non-empty string, right?  ;-)

[jiajia.qin, 2014/08/01 05:25:33]

Done.

+  }
+
   virtual void EnumerateDevicesSucceded(
       blink::WebMediaDevicesRequest* request,
       blink::WebVector<blink::WebMediaDeviceInfo>& devices) OVERRIDE {
     state_ = REQUEST_SUCCEEDED;
     last_devices_ = devices;
   }
 
   virtual MediaStreamVideoSource* CreateVideoSource(
       const StreamDeviceInfo& device,
       const MediaStreamSource::SourceStoppedCallback& stop_callback) OVERRIDE {
@@ skipping 19 matching lines @@
     return video_source_;
   }
 
   RequestState request_state() const { return state_; }
   content::MediaStreamRequestResult error_reason() const { return result_; }
 
  private:
   blink::WebMediaStream last_generated_stream_;
   RequestState state_;
   content::MediaStreamRequestResult result_;
+  blink::WebString result_name_;
   blink::WebVector<blink::WebMediaDeviceInfo> last_devices_;
   PeerConnectionDependencyFactory* factory_;
   MockMediaStreamVideoCapturerSource* video_source_;
 };
 
 class MediaStreamImplTest : public ::testing::Test {
  public:
   virtual void SetUp() {
     // Create our test object.
     child_process_.reset(new ChildProcess());
@@ skipping 333 matching lines @@
   EXPECT_FALSE(ms_impl_->last_devices()[3].groupId().isEmpty());
 
   // Verfify group IDs.
   EXPECT_TRUE(ms_impl_->last_devices()[0].groupId().equals(
                   ms_impl_->last_devices()[3].groupId()));
   EXPECT_FALSE(ms_impl_->last_devices()[1].groupId().equals(
                    ms_impl_->last_devices()[3].groupId()));
 }
 
 }  // namespace content