Issue 391693004: Enable the SSSE3 compile time check on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391693004: Enable the SSSE3 compile time check on all platforms. (Closed)

Created:
6 years, 5 months ago by djsollen

Modified:
6 years, 5 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Enable the SSSE3 compile time check on all platforms. BUG=skia:2746 Committed: https://skia.googlesource.com/skia/+/ee349531446ae2a8336b0903e05d0b2150d2131f

Patch Set 1 #

Patch Set 2 : more goodness #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
M	gyp/common_conditions.gypi	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/opts/SkBitmapProcState_opts_SSSE3.cpp	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/opts/SkBlurImage_opts_SSE4.cpp	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/391693004/20001

6 years, 5 months ago (2014-07-14 14:36:50 UTC) #4

commit-bot: I haz the power

Change committed as ee349531446ae2a8336b0903e05d0b2150d2131f

6 years, 5 months ago (2014-07-14 14:58:46 UTC) #5

hal.canary

6 years, 5 months ago (2014-07-14 15:31:45 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/390063002/ by halcanary@google.com.

The reason for reverting is: windows fail.

Expand Messages | Collapse Messages