Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 391483002: Revert 177812 "Migrate touch events to EventHandlerRegistry" (Closed)

Created:
6 years, 5 months ago by aarya
Modified:
6 years, 5 months ago
Reviewers:
Sami
CC:
blink-reviews
Visibility:
Public.

Description

Revert 177812 "Migrate touch events to EventHandlerRegistry" Causing ton of use-after-free crashes on ClusterFuzz. > Migrate touch events to EventHandlerRegistry > > Remove the specialized code for tracking touch events in favor of the > generic EventHandlerRegistry. Covered by existing tests. > > See https://codereview.chromium.org/206603002/ for full review history. > > BUG=347366 > TEST=fast/events/touch* > > Review URL: https://codereview.chromium.org/225903009 TBR=skyostil@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -202 lines) Patch
D trunk/LayoutTests/fast/events/move-event-handler-between-framehosts.html View 1 chunk +0 lines, -35 lines 0 comments Download
D trunk/LayoutTests/fast/events/move-event-handler-between-framehosts-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M trunk/LayoutTests/fast/events/touch/touch-action-touch-handlers.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/LayoutTests/fast/events/touch/touch-action-touch-handlers-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/LayoutTests/fast/events/touch/touch-handler-count.html View 1 chunk +7 lines, -7 lines 0 comments Download
M trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/Source/core/dom/Document.h View 4 chunks +21 lines, -0 lines 0 comments Download
M trunk/Source/core/dom/Document.cpp View 4 chunks +94 lines, -0 lines 0 comments Download
M trunk/Source/core/dom/Node.cpp View 5 chunks +19 lines, -6 lines 0 comments Download
M trunk/Source/core/frame/EventHandlerRegistry.h View 3 chunks +4 lines, -12 lines 0 comments Download
M trunk/Source/core/frame/EventHandlerRegistry.cpp View 7 chunks +25 lines, -44 lines 0 comments Download
M trunk/Source/core/frame/LocalDOMWindow.cpp View 4 chunks +16 lines, -1 line 0 comments Download
M trunk/Source/core/html/HTMLInputElement.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M trunk/Source/core/page/EventHandler.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +14 lines, -15 lines 0 comments Download
M trunk/Source/core/rendering/RenderObject.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M trunk/Source/core/testing/Internals.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M trunk/Source/web/WebPluginContainerImpl.cpp View 4 chunks +8 lines, -12 lines 0 comments Download
M trunk/Source/web/tests/WebViewTest.cpp View 4 chunks +29 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aarya
6 years, 5 months ago (2014-07-12 17:56:46 UTC) #1
aarya
6 years, 5 months ago (2014-07-12 17:57:33 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r177996.

Powered by Google App Engine
This is Rietveld 408576698