Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: trunk/Source/core/html/HTMLInputElement.cpp

Issue 391483002: Revert 177812 "Migrate touch events to EventHandlerRegistry" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/frame/LocalDOMWindow.cpp ('k') | trunk/Source/core/page/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/html/HTMLInputElement.cpp
===================================================================
--- trunk/Source/core/html/HTMLInputElement.cpp (revision 177995)
+++ trunk/Source/core/html/HTMLInputElement.cpp (working copy)
@@ -50,7 +50,6 @@
#include "core/events/ScopedEventQueue.h"
#include "core/events/TouchEvent.h"
#include "core/fileapi/FileList.h"
-#include "core/frame/EventHandlerRegistry.h"
#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
@@ -176,8 +175,8 @@
// We should unregister it to avoid accessing a deleted object.
if (isRadioButton())
document().formController().radioButtonGroupScope().removeButton(this);
- if (m_hasTouchEventHandler && document().frameHost())
- document().frameHost()->eventHandlerRegistry().didRemoveEventHandler(*this, EventHandlerRegistry::TouchEvent);
+ if (m_hasTouchEventHandler)
+ document().didRemoveTouchEventHandler(this);
#endif
}
@@ -428,14 +427,10 @@
bool hasTouchEventHandler = m_inputTypeView->hasTouchEventHandler();
if (hasTouchEventHandler != m_hasTouchEventHandler) {
- // If the Document is being or has been stopped, don't register any handlers.
- if (document().frameHost() && document().lifecycle().state() < DocumentLifecycle::Stopping) {
- EventHandlerRegistry& registry = document().frameHost()->eventHandlerRegistry();
- if (hasTouchEventHandler)
- registry.didAddEventHandler(*this, EventHandlerRegistry::TouchEvent);
- else
- registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchEvent);
- }
+ if (hasTouchEventHandler)
+ document().didAddTouchEventHandler(this);
+ else
+ document().didRemoveTouchEventHandler(this);
m_hasTouchEventHandler = hasTouchEventHandler;
}
@@ -1461,7 +1456,12 @@
if (isRadioButton())
oldDocument.formController().radioButtonGroupScope().removeButton(this);
+ if (m_hasTouchEventHandler)
+ oldDocument.didRemoveTouchEventHandler(this);
+ if (m_hasTouchEventHandler)
+ document().didAddTouchEventHandler(this);
+
HTMLTextFormControlElement::didMoveToNewDocument(oldDocument);
}
« no previous file with comments | « trunk/Source/core/frame/LocalDOMWindow.cpp ('k') | trunk/Source/core/page/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698