Issue 391413003: DevTools: [Timeline] extract common infrastructure from tracing tests.

Issue 391413003: DevTools: [Timeline] extract common infrastructure from tracing tests. (Closed)

Created:
6 years, 5 months ago by loislo

Modified:
6 years, 5 months ago

Reviewers:
caseq, alph, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [Timeline] extract common testing harness code from tracing tests. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178543

Patch Set 1 #

Patch Set 2 : findEvent was extacted #

Patch Set 3 : syntax error was fixed #

Total comments: 9

Patch Set 4 : comments addressed #

Patch Set 5 : comments addressed #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -178 lines)			Patch
M	LayoutTests/FlakyTests	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html	View		4 chunks	+4 lines, -4 lines	0 comments	Download
A	LayoutTests/http/tests/inspector-protocol/tracing-test.js	View	1 2 3	1 chunk	+107 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector-protocol/input/dispatchMouseEvent.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector-protocol/timeline/timeline-dispatchEvent.html	View		4 chunks	+7 lines, -36 lines	0 comments	Download
M	LayoutTests/inspector-protocol/timeline/timeline-layout.html	View	1	2 chunks	+11 lines, -48 lines	0 comments	Download
M	LayoutTests/inspector-protocol/timeline/timeline-raf.html	View	1	3 chunks	+9 lines, -43 lines	0 comments	Download
M	LayoutTests/inspector-protocol/timeline/timeline-timer.html	View	1	3 chunks	+9 lines, -43 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm w/ comments https://codereview.chromium.org/391413003/diff/40001/LayoutTests/http/tests/inspector-protocol/tracing-test.js File LayoutTests/http/tests/inspector-protocol/tracing-test.js (right): https://codereview.chromium.org/391413003/diff/40001/LayoutTests/http/tests/inspector-protocol/tracing-test.js#newcode1 LayoutTests/http/tests/inspector-protocol/tracing-test.js:1: // Copyright 2014 The Chromium Authors. ...

6 years, 5 months ago (2014-07-21 06:32:22 UTC) #2

loislo

https://codereview.chromium.org/391413003/diff/40001/LayoutTests/http/tests/inspector-protocol/tracing-test.js File LayoutTests/http/tests/inspector-protocol/tracing-test.js (right): https://codereview.chromium.org/391413003/diff/40001/LayoutTests/http/tests/inspector-protocol/tracing-test.js#newcode1 LayoutTests/http/tests/inspector-protocol/tracing-test.js:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...

6 years, 5 months ago (2014-07-21 07:28:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/391413003/80001

6 years, 5 months ago (2014-07-21 07:29:56 UTC) #5

Message was sent while issue was closed.

Change committed as 178543

Expand Messages | Collapse Messages