Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: LayoutTests/inspector-protocol/timeline/timeline-layout.html

Issue 391413003: DevTools: [Timeline] extract common infrastructure from tracing tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: comments addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector-protocol/timeline/timeline-layout.html
diff --git a/LayoutTests/inspector-protocol/timeline/timeline-layout.html b/LayoutTests/inspector-protocol/timeline/timeline-layout.html
index 60d77be9b00bf3f78aea79dc01ad6d1594b792c6..f2a0bd0057d1617d63b8dc9b500fe707dd6b880e 100644
--- a/LayoutTests/inspector-protocol/timeline/timeline-layout.html
+++ b/LayoutTests/inspector-protocol/timeline/timeline-layout.html
@@ -7,55 +7,32 @@
}
</style>
<script type="text/javascript" src="../../http/tests/inspector-protocol/inspector-protocol-test.js"></script>
+<script type="text/javascript" src="../../http/tests/inspector-protocol/tracing-test.js"></script>
<script>
-function testFunction()
+function performActions(callback)
{
var div = document.querySelector("#myDiv");
div.classList.add("my-class");
div.offsetWidth;
+ callback();
}
function test()
{
- InspectorTest.eventHandler["Tracing.dataCollected"] = dataCollected;
- InspectorTest.eventHandler["Tracing.tracingComplete"] = tracingComplete;
- InspectorTest.sendCommand("Tracing.start", { "categories" : "disabled-by-default-devtools.timeline", "type": "" }, onStart);
+ InspectorTest.invokeAsyncWithTracing("performActions", finish);
- function onStart(response)
+ function finish(devtoolsEvents)
{
- InspectorTest.log("Recording started");
- InspectorTest.sendCommand("Runtime.evaluate", { "expression": "testFunction()" }, didEvaluate);
- }
-
- function didEvaluate(response)
- {
- InspectorTest.sendCommand("Tracing.end", { }, onStop);
- }
-
- var devtoolsEvents = [];
- function dataCollected(reply)
- {
- var allEvents = reply.params.value;
- devtoolsEvents = devtoolsEvents.concat(allEvents.filter(function(e)
- {
- return e.cat === "disabled-by-default-devtools.timeline";
- }));
- }
-
- function tracingComplete(event)
- {
- InspectorTest.log("Tracing complete");
-
- var schedRecalc = findEvent("ScheduleStyleRecalculation", "I");
- var recalcBegin = findEvent("RecalculateStyles", "B");
- var recalcEnd = findEvent("RecalculateStyles", "E");
+ var schedRecalc = InspectorTest.findEvent("ScheduleStyleRecalculation", "I");
+ var recalcBegin = InspectorTest.findEvent("RecalculateStyles", "B");
+ var recalcEnd = InspectorTest.findEvent("RecalculateStyles", "E");
InspectorTest.assertEquals(schedRecalc.args.frame, recalcBegin.args.frame, "RecalculateStyles frame");
InspectorTest.assert(recalcEnd.args.elementCount > 0, "RecalculateStyles elementCount");
- var invalidate = findEvent("InvalidateLayout", "I");
- var layoutBegin = findEvent("Layout", "B");
- var layoutEnd = findEvent("Layout", "E");
+ var invalidate = InspectorTest.findEvent("InvalidateLayout", "I");
+ var layoutBegin = InspectorTest.findEvent("Layout", "B");
+ var layoutEnd = InspectorTest.findEvent("Layout", "E");
InspectorTest.assertEquals(recalcBegin.args.frame, invalidate.args.frame, "InvalidateLayout frame");
@@ -72,20 +49,6 @@ function test()
InspectorTest.completeTest();
}
- function findEvent(name, ph)
- {
- for (var i = 0; i < devtoolsEvents.length; i++) {
- var e = devtoolsEvents[i];
- if (e.name === name && e.ph === ph)
- return e;
- }
- throw new Error("Couldn't find event " + name + " / " + ph + "\n\n in " + JSON.stringify(devtoolsEvents, null, 2));
- }
-
- function onStop(response)
- {
- InspectorTest.log("Recording stopped");
- }
}
</script>
</head>

Powered by Google App Engine
This is Rietveld 408576698