Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: components/domain_reliability/monitor_unittest.cc

Issue 391383003: Domain Reliability: Update baked-in configs, add more (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/baked_in_configs/www_youtube_com.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/monitor_unittest.cc
diff --git a/components/domain_reliability/monitor_unittest.cc b/components/domain_reliability/monitor_unittest.cc
index 7678efdb27eb37c4d3dc9fe022b342fed4fc6aa4..f7ec3dec49d8df793bc574cf94eb8f1e0143cec9 100644
--- a/components/domain_reliability/monitor_unittest.cc
+++ b/components/domain_reliability/monitor_unittest.cc
@@ -236,8 +236,8 @@ TEST_F(DomainReliabilityMonitorTest, WasFetchedViaProxy) {
EXPECT_TRUE(beacons[0].server_ip.empty());
}
-// Disabled; does not handle when baked in configs expire.
-TEST_F(DomainReliabilityMonitorTest, DISABLED_AddBakedInConfigs) {
+// Will fail when baked-in configs expire, as a reminder to update them.
davidben 2014/07/16 21:03:19 Maybe add your username so that, if it fails, peop
Deprecated (see juliatuttle) 2014/07/16 21:39:23 Done.
+TEST_F(DomainReliabilityMonitorTest, AddBakedInConfigs) {
// AddBakedInConfigs DCHECKs that the baked-in configs parse correctly, so
// this unittest will fail if someone tries to add an invalid config to the
// source tree.
« no previous file with comments | « components/domain_reliability/baked_in_configs/www_youtube_com.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698