Domain Reliability: Update baked-in configs, add more

components/domain_reliability/monitor_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/monitor.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 218 matching lines @@
   OnRequestLegComplete(request);
 
   EXPECT_EQ(1u, CountPendingBeacons(kAlwaysReportIndex));
   EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 1u, 0u));
 
   BeaconVector beacons;
   context_->GetQueuedDataForTesting(kAlwaysReportIndex, &beacons, NULL, NULL);
   EXPECT_TRUE(beacons[0].server_ip.empty());
 }
 
-// Disabled; does not handle when baked in configs expire.
-TEST_F(DomainReliabilityMonitorTest, DISABLED_AddBakedInConfigs) {
+// Will fail when baked-in configs expire, as a reminder to update them.

[davidben, 2014/07/16 21:03:19]

Maybe add your username so that, if it fails, people know who to ping.

[Deprecated (see juliatuttle), 2014/07/16 21:39:23]

Done.

+TEST_F(DomainReliabilityMonitorTest, AddBakedInConfigs) {
   // AddBakedInConfigs DCHECKs that the baked-in configs parse correctly, so
   // this unittest will fail if someone tries to add an invalid config to the
   // source tree.
   monitor_.AddBakedInConfigs();
 
   // Count the number of baked-in configs.
   size_t num_baked_in_configs = 0;
   for (const char* const* p = kBakedInJsonConfigs; *p; ++p)
     ++num_baked_in_configs;
 
@@ skipping 49 matching lines @@
   EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 1u, 0u));
 
   BeaconVector beacons;
   context_->GetQueuedDataForTesting(kAlwaysReportIndex, &beacons, NULL, NULL);
   EXPECT_EQ(net::OK, beacons[0].chrome_error);
 }
 
 }  // namespace
 
 }  // namespace domain_reliability