Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 391383003: Domain Reliability: Update baked-in configs, add more (Closed)

Created:
6 years, 5 months ago by Deprecated (see juliatuttle)
Modified:
6 years, 5 months ago
Reviewers:
davidben, Ryan Sleevi
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Domain Reliability: Update baked-in configs, add more Add a bunch more baked-in configs, and update the existing ones. Also, improve bake_in_configs.py so it will display multiple errors before failing, and re-enable the unit test that failed when the existing configs expired. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283657

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add contact info to AddBakedInConfigs test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -100 lines) Patch
M components/domain_reliability.gypi View 1 chunk +28 lines, -0 lines 0 comments Download
M components/domain_reliability/bake_in_configs.py View 2 chunks +15 lines, -6 lines 0 comments Download
A components/domain_reliability/baked_in_configs/accounts_google_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/ad_doubleclick_net.json View 2 chunks +5 lines, -5 lines 0 comments Download
M components/domain_reliability/baked_in_configs/apis_google_com.json View 1 chunk +1 line, -1 line 0 comments Download
A + components/domain_reliability/baked_in_configs/c_admob_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/csi_gstatic_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
M components/domain_reliability/baked_in_configs/ddm_google_com.json View 1 chunk +1 line, -1 line 0 comments Download
A components/domain_reliability/baked_in_configs/docs_google_com.json View 1 chunk +36 lines, -0 lines 0 comments Download
M components/domain_reliability/baked_in_configs/drive_google_com.json View 1 chunk +1 line, -1 line 0 comments Download
A + components/domain_reliability/baked_in_configs/e_admob_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A components/domain_reliability/baked_in_configs/fonts_googleapis_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
A components/domain_reliability/baked_in_configs/googleads4_g_doubleclick_net.json View 1 chunk +18 lines, -0 lines 0 comments Download
A components/domain_reliability/baked_in_configs/googleads_g_doubleclick_net.json View 1 chunk +18 lines, -0 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/gstatic_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/lh3_ggpht_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/lh4_ggpht_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/lh5_ggpht_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/lh6_ggpht_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
M components/domain_reliability/baked_in_configs/mail_google_com.json View 1 chunk +1 line, -1 line 0 comments Download
A + components/domain_reliability/baked_in_configs/media_admob_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A components/domain_reliability/baked_in_configs/pagead2_googlesyndication_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
A components/domain_reliability/baked_in_configs/partner_googleadservices_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
A components/domain_reliability/baked_in_configs/pubads_g_doubleclick_net.json View 1 chunk +18 lines, -0 lines 0 comments Download
A components/domain_reliability/baked_in_configs/redirector_googlevideo_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
A components/domain_reliability/baked_in_configs/redirector_gvt1_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/s0_2mdn_net.json View 2 chunks +5 lines, -5 lines 0 comments Download
M components/domain_reliability/baked_in_configs/ssl_gstatic_com.json View 1 chunk +1 line, -1 line 0 comments Download
A + components/domain_reliability/baked_in_configs/t0_gstatic_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/t1_gstatic_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/t2_gstatic_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/t3_gstatic_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
A components/domain_reliability/baked_in_configs/themes_googleusercontent_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
M components/domain_reliability/baked_in_configs/www_google_com.json View 2 chunks +36 lines, -6 lines 0 comments Download
A components/domain_reliability/baked_in_configs/www_googleadservices_com.json View 1 chunk +18 lines, -0 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/www_gstatic_com.json View 2 chunks +5 lines, -5 lines 0 comments Download
M components/domain_reliability/baked_in_configs/www_youtube_com.json View 1 chunk +1 line, -1 line 0 comments Download
M components/domain_reliability/monitor_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Deprecated (see juliatuttle)
PTAL, davidben.
6 years, 5 months ago (2014-07-16 20:38:53 UTC) #1
davidben
lgtm with comment https://codereview.chromium.org/391383003/diff/1/components/domain_reliability/monitor_unittest.cc File components/domain_reliability/monitor_unittest.cc (right): https://codereview.chromium.org/391383003/diff/1/components/domain_reliability/monitor_unittest.cc#newcode239 components/domain_reliability/monitor_unittest.cc:239: // Will fail when baked-in configs ...
6 years, 5 months ago (2014-07-16 21:03:19 UTC) #2
Deprecated (see juliatuttle)
https://codereview.chromium.org/391383003/diff/1/components/domain_reliability/monitor_unittest.cc File components/domain_reliability/monitor_unittest.cc (right): https://codereview.chromium.org/391383003/diff/1/components/domain_reliability/monitor_unittest.cc#newcode239 components/domain_reliability/monitor_unittest.cc:239: // Will fail when baked-in configs expire, as a ...
6 years, 5 months ago (2014-07-16 21:39:23 UTC) #3
Deprecated (see juliatuttle)
The CQ bit was checked by ttuttle@chromium.org
6 years, 5 months ago (2014-07-16 21:39:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/391383003/20001
6 years, 5 months ago (2014-07-16 21:43:21 UTC) #5
commit-bot: I haz the power
Change committed as 283657
6 years, 5 months ago (2014-07-17 06:18:45 UTC) #6
Ryan Sleevi
6 years, 5 months ago (2014-07-21 21:38:43 UTC) #7
Message was sent while issue was closed.
For any modifications to this whitelist, please update the bug that was
security-review'd.

Not trying to be a pain in the butt, but the review was approved on the caveat
of a limited whitelist, and expanding that whitelist should keep them in the
loop.

Powered by Google App Engine
This is Rietveld 408576698