Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: sdk/lib/_internal/pub/test/list_package_dirs/pubspec_error_test.dart

Issue 391363004: Include file path in JSON error when possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/list_package_dirs/pubspec_error_test.dart
diff --git a/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart b/sdk/lib/_internal/pub/test/list_package_dirs/pubspec_error_test.dart
similarity index 58%
copy from sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart
copy to sdk/lib/_internal/pub/test/list_package_dirs/pubspec_error_test.dart
index da2feb35130202af39eb43d6f128f50b896ee4c0..6e4a4ee4b16e6433d4d84fb0e06f0b756e094191 100644
--- a/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart
+++ b/sdk/lib/_internal/pub/test/list_package_dirs/pubspec_error_test.dart
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE d.file.
import 'package:path/path.dart' as path;
+import 'package:scheduled_test/scheduled_test.dart';
import '../../lib/src/exit_codes.dart' as exit_codes;
import '../../lib/src/io.dart';
@@ -11,16 +12,16 @@ import '../test_pub.dart';
main() {
initConfig();
- // This is a regression test for #20065.
- integration("reports a missing pubspec error using JSON", () {
- d.dir(appPath).create();
+ integration("reports the pubspec path when there is an error in it", () {
+ d.dir(appPath, [
+ d.file("pubspec.yaml", "some bad yaml")
+ ]).create();
schedulePub(args: ["list-package-dirs", "--format=json"],
outputJson: {
- "error":
- 'Could not find a file named "pubspec.yaml" in "'
- '${canonicalize(path.join(sandboxDir, appPath))}".'
+ "error": contains('Error on line 1'),
+ "path": canonicalize(path.join(sandboxDir, appPath, "pubspec.yaml"))
},
- exitCode: 1);
+ exitCode: exit_codes.DATA);
});
}

Powered by Google App Engine
This is Rietveld 408576698