sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart - Issue 391363004: Include file path in JSON error when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart

Issue 391363004: Include file path in JSON error when possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Revise. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/pub/lib/src/lock_file.dart ('K') | « sdk/lib/_internal/pub/test/list_package_dirs/lockfile_error_test.dart ('k') | sdk/lib/_internal/pub/test/list_package_dirs/pubspec_error_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart

diff --git a/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart b/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart

index da2feb35130202af39eb43d6f128f50b896ee4c0..ea32e58a2f8ae3f45bcaf4f3bd37965610edcbf5 100644

--- a/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart

+++ b/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart

@@ -4,7 +4,6 @@

import 'package:path/path.dart' as path;

-import '../../lib/src/exit_codes.dart' as exit_codes;

import '../../lib/src/io.dart';

import '../descriptor.dart' as d;

import '../test_pub.dart';

@@ -19,7 +18,8 @@ main() {

outputJson: {

"error":

'Could not find a file named "pubspec.yaml" in "'

- '${canonicalize(path.join(sandboxDir, appPath))}".'

+ '${canonicalize(path.join(sandboxDir, appPath))}".',

+ "path": canonicalize(path.join(sandboxDir, appPath, "pubspec.yaml"))

exitCode: 1);

});