Issue 39125: Try to fix a Purify UMR error. This isn't great, but it's better than nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39125: Try to fix a Purify UMR error. This isn't great, but it's better than nothing. (Closed)

Created:
11 years, 9 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews, Peter Kasting

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Try to fix a Purify UMR error. This isn't great, but it's better than nothing. BUG=8314

Patch Set 2 : Bug id #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Hey, This is a pretty lame fix, but I don't have time to really investigate ...

11 years, 9 months ago (2009-03-04 10:59:56 UTC) #1

Erik does not do reviews

LGTM http://codereview.chromium.org/39125/diff/1/2 File chrome/browser/autocomplete/autocomplete_edit_view_win.cc (right): http://codereview.chromium.org/39125/diff/1/2#newcode1829 Line 1829: // Save the selection. TODO(deanm): Purify started ...

11 years, 9 months ago (2009-03-04 16:26:20 UTC) #2

Peter Kasting

11 years, 9 months ago (2009-03-04 17:31:16 UTC) #3

Sounds from the bug like maybe some other code has been implicated.  If so,
maybe we should go ahead and revert this?  It's a pretty harmless change so no
rush.

Expand Messages | Collapse Messages

Issue 39125: Try to fix a Purify UMR error. This isn't great, but it's better than nothing. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Bug id #

Messages