Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Issue 39125: Try to fix a Purify UMR error. This isn't great, but it's better than nothing. (Closed)
Patch Set: Bug id Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit_view_win.cc
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
index 287cfdaffa171e471f878dde658e078539148024..307f50205398c614da9f1bb27c11ab622d3489cb 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
@@ -1826,8 +1826,11 @@ void AutocompleteEditViewWin::EmphasizeURLComponents() {
ScopedFreeze freeze(this, text_object_model);
ScopedSuspendUndo suspend_undo(text_object_model);
- // Save the selection.
- CHARRANGE saved_sel;
+ // Save the selection. Bug 8314: Purify started reporting uninitialized
+ // memory access in saved_sel. This would suggest that GetSelection(), which
+ // is calling the rich edit's GetSel() is failing. I'm not sure how or why
+ // this would happen. For now just initialize the CHARRANGE to be safe.
+ CHARRANGE saved_sel = {0, 0};
GetSelection(saved_sel);
// See whether the contents are a URL with a non-empty host portion, which we
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698