Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: tools/perf/metrics/iometric.py

Issue 391183002: Delete trace-info.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed descriptions in smoothness_controller. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/perf/metrics/memory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/iometric.py
diff --git a/tools/perf/metrics/iometric.py b/tools/perf/metrics/iometric.py
index b092aab419c620c387f6ed090c7ef874f41c2800..b6d9bccb61c7668f90ed98021f157124e361699d 100644
--- a/tools/perf/metrics/iometric.py
+++ b/tools/perf/metrics/iometric.py
@@ -42,7 +42,8 @@ class IOMetric(Metric):
process_type_trace: String to be added to the trace name in the results.
"""
- def AddSummaryForOperation(operation_name, trace_name_prefix, units):
+ def AddSummaryForOperation(operation_name, trace_name_prefix, units,
+ description):
"""Adds summary results for an operation in a process.
Args:
@@ -55,13 +56,17 @@ class IOMetric(Metric):
value = value / 1024
results.AddSummaryValue(
scalar.ScalarValue(None, trace_name_prefix + process_type_trace,
- units, value, important=False))
+ units, value, important=False,
+ description=description))
- AddSummaryForOperation('ReadOperationCount', 'read_operations_', 'count')
+ AddSummaryForOperation('ReadOperationCount', 'read_operations_', 'count',
+ 'Number of IO read operations.')
AddSummaryForOperation('WriteOperationCount', 'write_operations_',
- 'count')
- AddSummaryForOperation('ReadTransferCount', 'read_bytes_', 'kb')
- AddSummaryForOperation('WriteTransferCount', 'write_bytes_', 'kb')
+ 'count', 'Number of IO write operations.')
+ AddSummaryForOperation('ReadTransferCount', 'read_bytes_', 'kb',
+ 'Number of IO bytes read.')
+ AddSummaryForOperation('WriteTransferCount', 'write_bytes_', 'kb',
+ 'Number of IO bytes written.')
AddSummariesForProcessType('Browser', 'browser')
AddSummariesForProcessType('Renderer', 'renderer')
« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/perf/metrics/memory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698