Changes to Intel shift functions...

Changes to Intel shift functions

Change name of shifts picking the shift count from cl to sal_cl, shl_cl and shr_cl.

Add special encoding of shift by one for shr which was missing it.

Committed: http://code.google.com/p/v8/source/detail?r=3314

[Søren Thygesen Gjesse, 2009-11-16 16:38:22]

I also considered using a form taking two registers and asserting that the
second (the shift amount) was always ecx, but decided against it.

[Lasse Reichstein, 2009-11-17 08:30:36]

LGTM

http://codereview.chromium.org/391073/diff/1/4
File src/ia32/assembler-ia32.cc (left):

http://codereview.chromium.org/391073/diff/1/4#oldcode1172
Line 1172: EMIT(0xD1);
So this one was actually wrong before. Was it used?

[Søren Thygesen Gjesse, 2009-11-17 08:35:10]

http://codereview.chromium.org/391073/diff/1/4
File src/ia32/assembler-ia32.cc (left):

http://codereview.chromium.org/391073/diff/1/4#oldcode1172
Line 1172: EMIT(0xD1);
On 2009/11/17 08:30:36, Lasse Reichstein wrote:
> So this one was actually wrong before. Was it used?

It was wrong but not used.