Avoid inconsistent state (leading to checkfailures) due to Windows minimize/r...

Avoid inconsistent state (leading to checkfailures) due to Windows minimize/restore functionality hiding and showing the autocomplete dropdown outside of the awareness of the controller.

Instead, this switches to the simpler model of just creating a new HWND when we want to show the dropdown, and destroying it when we want to close it.  Happily, this also seems to save quite a bit of code.

BUG=20511
TEST=Type a character in the omnibox, minimize the window, and restore it.  The dropdown should have disappeared.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31649

[Peter Kasting, 2009-11-11 03:37:12]

Reviewers: Ben Goodger,

Description:
Avoid inconsistent state (leading to checkfailures) due to Windows
minimize/restore functionality hiding and showing the autocomplete dropdown
outside of the awareness of the controller.

Instead, this switches to the simpler model of just creating a new HWND  
when we
want to show the dropdown, and destroying it when we want to close it.   
Happily,
this also seems to save quite a bit of code.

BUG=20511
TEST=Type a character in the omnibox, minimize the window, and restore it.   
The
dropdown should have disappeared.

Please review this at http://codereview.chromium.org/391011

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/autocomplete/autocomplete_popup_model.cc
   M     chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M      
chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M     chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M     chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M     chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M     chrome/browser/views/autocomplete/autocomplete_popup_win.cc

[Ben Goodger (Google), 2009-11-11 04:43:50]

LGTM

[Ben Goodger (Google), 2009-11-11 04:44:12]

LGTM

http://codereview.chromium.org/391011