Avoid inconsistent state (leading to checkfailures) due to Windows minimize/r...

chrome/browser/autocomplete/autocomplete_popup_model.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_popup_model.h"
 
 #include "base/string_util.h"
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
 #include "chrome/browser/autocomplete/autocomplete_popup_view.h"
 #include "chrome/browser/profile.h"
@@ skipping 157 matching lines @@
     // The query isn't running, so the standard result set can't possibly be out
     // of date.
     //
     // NOTE: In practice, it should actually be safe to use
     // controller_->latest_result() here too, since the controller keeps that
     // up-to-date.  However we generally try to avoid referring to that.
     result = &controller_->result();
     // If there are no results, the popup should be closed (so we should have
     // failed the CHECK above), and URLsForDefaultMatch() should have been
     // called instead.
-    if (result->empty()) {
-      // We're going to checkfail, but first see whether
-      // controller_->latest_result() is actually in sync with |result|.
-      CHECK(controller_->latest_result().empty());
-      CHECK(false);
-    }
+    CHECK(!result->empty());
     CHECK(selected_line_ < result->size());
     match = result->begin() + selected_line_;
   }
   if (transition)
     *transition = match->transition;
   if (is_history_what_you_typed_match)
     *is_history_what_you_typed_match = match->is_history_what_you_typed_match;
   if (alternate_nav_url && manually_selected_match_.empty())
     *alternate_nav_url = result->alternate_nav_url();
   return match->destination_url;
@@ skipping 89 matching lines @@
   // There had better not be a nonempty result set with no default match.
   CHECK((selected_line_ != kNoMatch) || result->empty());
   // If we're going to trim the window size to no longer include the hovered
   // line, turn hover off.  Practically, this shouldn't happen, but it
   // doesn't hurt to be defensive.
   if ((hovered_line_ != kNoMatch) && (result->size() <= hovered_line_))
     SetHoveredLine(kNoMatch);
 
   view_->UpdatePopupAppearance();
 }