Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 390983003: Remove remoting/jingle_glue (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
rmsousa, Ryan Hamilton
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove remoting/jingle_glue Moved all files from remoting/jingle_glue to remoting/signaling and remoting/protocol. The new remoting/signaling directory contains signaling layer implementation for remoting that can be used independently of remoting/protocol. TBR=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283654

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -3012 lines) Patch
M remoting/client/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/client_status_logger.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/client_status_logger_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/client/plugin/delegating_signal_strategy.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/server_log_entry_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/server_log_entry_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/heartbeat_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/heartbeat_sender.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/heartbeat_sender_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/host_change_notification_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_change_notification_listener.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_change_notification_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_status_logger.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_status_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_status_logger_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_status_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_status_sender.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/host_status_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/it2me/it2me_host.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/it2me/it2me_host.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M remoting/host/register_support_host_request.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/host/server_log_entry_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/server_log_entry_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/session_manager_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/session_manager_factory.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/signaling_connector.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/ios/bridge/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/ios/bridge/client_instance.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/ios/bridge/client_instance.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
D remoting/jingle_glue/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D remoting/jingle_glue/chromium_port_allocator.h View 1 chunk +0 lines, -55 lines 0 comments Download
D remoting/jingle_glue/chromium_port_allocator.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D remoting/jingle_glue/chromium_socket_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D remoting/jingle_glue/chromium_socket_factory.cc View 1 chunk +0 lines, -395 lines 0 comments Download
D remoting/jingle_glue/chromium_socket_factory_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D remoting/jingle_glue/fake_signal_strategy.h View 1 chunk +0 lines, -68 lines 0 comments Download
D remoting/jingle_glue/fake_signal_strategy.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D remoting/jingle_glue/iq_sender.h View 1 chunk +0 lines, -113 lines 0 comments Download
D remoting/jingle_glue/iq_sender.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D remoting/jingle_glue/iq_sender_unittest.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D remoting/jingle_glue/jingle_info_request.h View 1 chunk +0 lines, -64 lines 0 comments Download
D remoting/jingle_glue/jingle_info_request.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D remoting/jingle_glue/log_to_server.h View 1 chunk +0 lines, -60 lines 0 comments Download
D remoting/jingle_glue/log_to_server.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D remoting/jingle_glue/log_to_server_unittest.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D remoting/jingle_glue/mock_objects.h View 1 chunk +0 lines, -35 lines 0 comments Download
D remoting/jingle_glue/mock_objects.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D remoting/jingle_glue/network_settings.h View 1 chunk +0 lines, -74 lines 0 comments Download
D remoting/jingle_glue/network_settings.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D remoting/jingle_glue/network_settings_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D remoting/jingle_glue/server_log_entry.h View 1 chunk +0 lines, -64 lines 0 comments Download
D remoting/jingle_glue/server_log_entry.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D remoting/jingle_glue/server_log_entry_unittest.h View 1 chunk +0 lines, -36 lines 0 comments Download
D remoting/jingle_glue/server_log_entry_unittest.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D remoting/jingle_glue/signal_strategy.h View 1 chunk +0 lines, -101 lines 0 comments Download
D remoting/jingle_glue/socket_util.h View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/jingle_glue/socket_util.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D remoting/jingle_glue/xmpp_signal_strategy.h View 1 chunk +0 lines, -115 lines 0 comments Download
D remoting/jingle_glue/xmpp_signal_strategy.cc View 1 chunk +0 lines, -251 lines 0 comments Download
M remoting/protocol/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/protocol/chromium_port_allocator.h View 3 chunks +4 lines, -2 lines 0 comments Download
A + remoting/protocol/chromium_port_allocator.cc View 4 chunks +6 lines, -4 lines 0 comments Download
A + remoting/protocol/chromium_socket_factory.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + remoting/protocol/chromium_socket_factory.cc View 3 chunks +4 lines, -2 lines 0 comments Download
A + remoting/protocol/chromium_socket_factory_unittest.cc View 3 chunks +3 lines, -1 line 0 comments Download
M remoting/protocol/connection_to_host.h View 1 2 chunks +1 line, -1 line 0 comments Download
M remoting/protocol/connection_to_host.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/jingle_session.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/protocol/network_settings.h View 3 chunks +4 lines, -2 lines 0 comments Download
A + remoting/protocol/network_settings.cc View 3 chunks +3 lines, -1 line 0 comments Download
A + remoting/protocol/network_settings_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
A + remoting/protocol/socket_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/protocol/socket_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_srcs.gypi View 5 chunks +19 lines, -19 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
A + remoting/signaling/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/signaling/fake_signal_strategy.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + remoting/signaling/fake_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/signaling/iq_sender.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + remoting/signaling/iq_sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + remoting/signaling/iq_sender_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/signaling/jingle_info_request.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + remoting/signaling/jingle_info_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + remoting/signaling/log_to_server.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + remoting/signaling/log_to_server.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/signaling/log_to_server_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/signaling/mock_signal_strategy.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/signaling/mock_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/signaling/server_log_entry.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/signaling/server_log_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/signaling/server_log_entry_unittest.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/signaling/server_log_entry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/signaling/signal_strategy.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/signaling/xmpp_signal_strategy.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-14 22:38:14 UTC) #1
Sergey Ulanov
Renato: ping
6 years, 5 months ago (2014-07-16 18:49:57 UTC) #2
rmsousa
lgtm lgtm This looks good, although I'm not sure what exactly is the criteria for ...
6 years, 5 months ago (2014-07-16 20:56:18 UTC) #3
Sergey Ulanov
On 2014/07/16 20:56:18, rmsousa wrote: > lgtm > > lgtm > > This looks good, ...
6 years, 5 months ago (2014-07-16 21:06:59 UTC) #4
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 21:08:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/390983003/20001
6 years, 5 months ago (2014-07-16 21:10:19 UTC) #6
Sergey Ulanov
+rch@chromium.org in TBR for moved dependency on src/net
6 years, 5 months ago (2014-07-16 22:32:44 UTC) #7
Sergey Ulanov
+rch@chromium.org in TBR for moved dependency on src/net
6 years, 5 months ago (2014-07-16 22:32:44 UTC) #8
Sergey Ulanov
The CQ bit was unchecked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 22:33:06 UTC) #9
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 22:33:06 UTC) #10
Ryan Hamilton
On 2014/07/16 22:32:44, Sergey Ulanov wrote: > rch@chromium.org in TBR for moved dependency on src/net ...
6 years, 5 months ago (2014-07-16 22:33:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/390983003/20001
6 years, 5 months ago (2014-07-16 22:35:00 UTC) #12
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-17 01:09:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/390983003/40001
6 years, 5 months ago (2014-07-17 01:11:32 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:10:26 UTC) #15
Message was sent while issue was closed.
Change committed as 283654

Powered by Google App Engine
This is Rietveld 408576698