android: Fix parameter for onFinishGetBitmap in ContentReadbackHandler

android: Fix parameter for onFinishGetBitmap in ContentReadbackHandler

The boolean parameter is not necessary as we can just use null to indicate
readback failure.

android= https://chrome-internal-review.googlesource.com/#/c/169047/
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285609

[powei, 2014-07-23 17:52:39]

PTAL.  Thanks!

[Ted C, 2014-07-23 19:39:12]

https://codereview.chromium.org/390933003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
(right):

https://codereview.chromium.org/390933003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java:27:
* @param bitmap     The {@link Bitmap} of the content.
should comment that it can be null to indicate failure?

https://codereview.chromium.org/390933003/diff/1/content/public/android/javat...
File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java
(right):

https://codereview.chromium.org/390933003/diff/1/content/public/android/javat...
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java:109:
assertTrue("Readback did not return bitmap", bitmap != null);
there should be an assertNotNull instead of assertTrue

[Ted C, 2014-07-23 19:40:13]

On 2014/07/23 19:39:12, Ted C wrote:
>
https://codereview.chromium.org/390933003/diff/1/content/public/android/java/...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
> (right):
> 
>
https://codereview.chromium.org/390933003/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java:27:
> * @param bitmap     The {@link Bitmap} of the content.
> should comment that it can be null to indicate failure?
> 
>
https://codereview.chromium.org/390933003/diff/1/content/public/android/javat...
> File
>
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java
> (right):
> 
>
https://codereview.chromium.org/390933003/diff/1/content/public/android/javat...
>
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java:109:
> assertTrue("Readback did not return bitmap", bitmap != null);
> there should be an assertNotNull instead of assertTrue

oh...and lgtm

[powei, 2014-07-25 16:27:44]

https://codereview.chromium.org/390933003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
(right):

https://codereview.chromium.org/390933003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java:27:
* @param bitmap     The {@link Bitmap} of the content.
On 2014/07/23 19:39:11, Ted C wrote:
> should comment that it can be null to indicate failure?

Done.

https://codereview.chromium.org/390933003/diff/1/content/public/android/javat...
File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java
(right):

https://codereview.chromium.org/390933003/diff/1/content/public/android/javat...
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java:109:
assertTrue("Readback did not return bitmap", bitmap != null);
On 2014/07/23 19:39:11, Ted C wrote:
> there should be an assertNotNull instead of assertTrue

Done.

[powei, 2014-07-25 16:28:56]

The CQ bit was checked by powei@chromium.org

[commit-bot: I haz the power, 2014-07-25 16:29:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/powei@chromium.org/390933003/20001

[commit-bot: I haz the power, 2014-07-25 17:21:47]

Change committed as 285609