Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java

Issue 390933003: android: Fix parameter for onFinishGetBitmap in ContentReadbackHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java b/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
index 15226d51462bd260af41ce2730a3dcec266ea143..76951c1ee57ece905e8b78189ed1ccd5d84c1095 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
@@ -24,10 +24,10 @@ public abstract class ContentReadbackHandler {
public static interface GetBitmapCallback {
/**
* Called when the content readback finishes.
- * @param success Indicates whether the readback succeeded or not.
- * @param bitmap The {@link Bitmap} of the content.
+ * @param bitmap The {@link Bitmap} of the content. Null will be passed for readback
+ * failure.
*/
- public void onFinishGetBitmap(boolean success, Bitmap bitmap);
+ public void onFinishGetBitmap(Bitmap bitmap);
}
private int mNextReadbackId = 1;
@@ -59,11 +59,11 @@ public abstract class ContentReadbackHandler {
@CalledByNative
- private void notifyGetBitmapFinished(int readbackId, boolean success, Bitmap bitmap) {
+ private void notifyGetBitmapFinished(int readbackId, Bitmap bitmap) {
GetBitmapCallback callback = mGetBitmapRequests.get(readbackId);
if (callback != null) {
mGetBitmapRequests.delete(readbackId);
- callback.onFinishGetBitmap(success, bitmap);
+ callback.onFinishGetBitmap(bitmap);
} else {
// readback Id is unregistered.
assert false : "Readback finished for unregistered Id: " + readbackId;
@@ -83,7 +83,7 @@ public abstract class ContentReadbackHandler {
public void getContentBitmapAsync(float scale, Rect srcRect, ContentViewCore view,
GetBitmapCallback callback) {
if (!readyForReadback()) {
- callback.onFinishGetBitmap(false, null);
+ callback.onFinishGetBitmap(null);
return;
}
ThreadUtils.assertOnUiThread();
@@ -103,7 +103,7 @@ public abstract class ContentReadbackHandler {
*/
public void getCompositorBitmapAsync(WindowAndroid windowAndroid, GetBitmapCallback callback) {
if (!readyForReadback()) {
- callback.onFinishGetBitmap(false, null);
+ callback.onFinishGetBitmap(null);
return;
}
ThreadUtils.assertOnUiThread();

Powered by Google App Engine
This is Rietveld 408576698