Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 390833003: Remove PropertyAttributes from SetProperty (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko, dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Remove PropertyAttributes from SetProperty BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -208 lines) Patch
M include/v8.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/api.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M src/debug.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/i18n.cc View 30 chunks +0 lines, -40 lines 0 comments Download
M src/ic.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M src/isolate.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/liveedit.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/objects.h View 7 chunks +0 lines, -8 lines 0 comments Download
M src/objects.cc View 19 chunks +22 lines, -37 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -8 lines 0 comments Download
M src/runtime.cc View 11 chunks +16 lines, -19 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 8 chunks +15 lines, -12 lines 0 comments Download
M test/cctest/test-heap.cc View 11 chunks +20 lines, -25 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-14 14:16:06 UTC) #1
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-14 14:42:26 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-14 14:52:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22383 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698