Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/runtime.h

Issue 390833003: Remove PropertyAttributes from SetProperty (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_RUNTIME_H_ 5 #ifndef V8_RUNTIME_H_
6 #define V8_RUNTIME_H_ 6 #define V8_RUNTIME_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/zone.h" 9 #include "src/zone.h"
10 10
(...skipping 784 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 // TODO(1240886): Some of the following methods are *not* handle safe, but 795 // TODO(1240886): Some of the following methods are *not* handle safe, but
796 // accept handle arguments. This seems fragile. 796 // accept handle arguments. This seems fragile.
797 797
798 // Support getting the characters in a string using [] notation as 798 // Support getting the characters in a string using [] notation as
799 // in Firefox/SpiderMonkey, Safari and Opera. 799 // in Firefox/SpiderMonkey, Safari and Opera.
800 MUST_USE_RESULT static MaybeHandle<Object> GetElementOrCharAt( 800 MUST_USE_RESULT static MaybeHandle<Object> GetElementOrCharAt(
801 Isolate* isolate, 801 Isolate* isolate,
802 Handle<Object> object, 802 Handle<Object> object,
803 uint32_t index); 803 uint32_t index);
804 804
805 // Do not use SetObjectProperty to configure a property with specific
806 // attributes. The argument will be removed once the API is adapted.
807 MUST_USE_RESULT static MaybeHandle<Object> SetObjectProperty( 805 MUST_USE_RESULT static MaybeHandle<Object> SetObjectProperty(
808 Isolate* isolate, 806 Isolate* isolate, Handle<Object> object, Handle<Object> key,
809 Handle<Object> object, 807 Handle<Object> value, StrictMode strict_mode);
810 Handle<Object> key,
811 Handle<Object> value,
812 StrictMode strict_mode,
813 PropertyAttributes attributes = NONE);
814 808
815 MUST_USE_RESULT static MaybeHandle<Object> DefineObjectProperty( 809 MUST_USE_RESULT static MaybeHandle<Object> DefineObjectProperty(
816 Handle<JSObject> object, 810 Handle<JSObject> object,
817 Handle<Object> key, 811 Handle<Object> key,
818 Handle<Object> value, 812 Handle<Object> value,
819 PropertyAttributes attr, 813 PropertyAttributes attr,
820 JSReceiver::StoreFromKeyed store_from_keyed = 814 JSReceiver::StoreFromKeyed store_from_keyed =
821 JSReceiver::MAY_BE_STORE_FROM_KEYED); 815 JSReceiver::MAY_BE_STORE_FROM_KEYED);
822 816
823 MUST_USE_RESULT static MaybeHandle<Object> DeleteObjectProperty( 817 MUST_USE_RESULT static MaybeHandle<Object> DeleteObjectProperty(
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 class AllocateDoubleAlignFlag: public BitField<bool, 0, 1> {}; 884 class AllocateDoubleAlignFlag: public BitField<bool, 0, 1> {};
891 class AllocateTargetSpace: public BitField<AllocationSpace, 1, 3> {}; 885 class AllocateTargetSpace: public BitField<AllocationSpace, 1, 3> {};
892 886
893 class DeclareGlobalsEvalFlag: public BitField<bool, 0, 1> {}; 887 class DeclareGlobalsEvalFlag: public BitField<bool, 0, 1> {};
894 class DeclareGlobalsNativeFlag: public BitField<bool, 1, 1> {}; 888 class DeclareGlobalsNativeFlag: public BitField<bool, 1, 1> {};
895 class DeclareGlobalsStrictMode: public BitField<StrictMode, 2, 1> {}; 889 class DeclareGlobalsStrictMode: public BitField<StrictMode, 2, 1> {};
896 890
897 } } // namespace v8::internal 891 } } // namespace v8::internal
898 892
899 #endif // V8_RUNTIME_H_ 893 #endif // V8_RUNTIME_H_
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698