components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc - Issue 390533003: Bypassed Bytes UMAs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

Issue 390533003: Bypassed Bytes UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed logging and fixed MaybeBypassProxyAndPrepareToRetry Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

index 65535764d755a29ebeb81c0ecee72aa95f1c79cd..e0c00b0ebbeeabf8acd548ea12267e7f656d1c32 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

@@ -68,6 +68,7 @@ class TestDataReductionProxyNetworkDelegate : public net::NetworkDelegate {

scoped_refptr<HttpResponseHeaders>* override_response_headers,

GURL* allowed_unsafe_redirect_url) OVERRIDE {

data_reduction_proxy::MaybeBypassProxyAndPrepareToRetry(

+ NULL,

bengr 2014/07/16 01:40:10 You should also test that if you pass in non-NULL,

test_data_reduction_proxy_params_,

request,

original_response_headers,