Bypassed Bytes UMAs

components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h"
 
 #include <utility>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 50 matching lines @@
       : net::NetworkDelegate(), test_data_reduction_proxy_params_(test_params) {
   }
 
   virtual int OnHeadersReceived(
       URLRequest* request,
       const net::CompletionCallback& callback,
       const HttpResponseHeaders* original_response_headers,
       scoped_refptr<HttpResponseHeaders>* override_response_headers,
       GURL* allowed_unsafe_redirect_url) OVERRIDE {
     data_reduction_proxy::MaybeBypassProxyAndPrepareToRetry(
+        NULL,

[bengr, 2014/07/16 01:40:10]

You should also test that if you pass in non-NULL, the correct type is returned.

         test_data_reduction_proxy_params_,
         request,
         original_response_headers,
         override_response_headers);
     return net::OK;
   }
 
   TestDataReductionProxyParams* test_data_reduction_proxy_params_;
 };
 
@@ skipping 603 matching lines @@
   load_flags |= net::LOAD_BYPASS_DATA_REDUCTION_PROXY;
 
   OnResolveProxyHandler(url, load_flags, &test_params, &info2);
   EXPECT_FALSE(info2.is_direct());
 
   OnResolveProxyHandler(url, load_flags, &test_params, &info1);
   EXPECT_TRUE(info1.is_direct());
 }
 
 }  // namespace data_reduction_proxy