components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h - Issue 390533003: Bypassed Bytes UMAs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h

Issue 390533003: Bypassed Bytes UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed logging and fixed MaybeBypassProxyAndPrepareToRetry Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/browser/data_reduction_proxy_params.cc ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_params.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h

index 03c2a8f100b8f47f09b75faea15d7cde7a6eca5a..fb7de076f1ed9764d8f9ec7b5ac263454c03ed5e 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "base/memory/ref_counted.h"

+#include "net/proxy/proxy_service.h"

namespace base {

class TimeDelta;

@@ -29,6 +30,7 @@ class DataReductionProxyParams;

// put it on the proxy retry list. Returns true if the request should be

// retried. Sets |override_response_headers| to redirect if so.

bool MaybeBypassProxyAndPrepareToRetry(

+ net::ProxyService::DataReductionProxyBypassType* proxy_bypass_type,

bengr 2014/07/16 01:40:10 Explain in the comment what this new paramater is

megjablon 2014/07/16 23:07:14 Done.

const DataReductionProxyParams* params,

net::URLRequest* request,

const net::HttpResponseHeaders* original_response_headers,