Bypassed Bytes UMAs

components/data_reduction_proxy/browser/data_reduction_proxy_protocol.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PROTOCOL_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PROTOCOL_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "net/proxy/proxy_service.h"
 
 namespace base {
 class TimeDelta;
 }
 
 namespace net {
 class HttpResponseHeaders;
 class ProxyInfo;
 class ProxyServer;
 class URLRequest;
 }
 
 class GURL;
 
 namespace data_reduction_proxy {
 
 class DataReductionProxyParams;
 
 // Decides whether to mark the data reduction proxy as temporarily bad and
 // put it on the proxy retry list. Returns true if the request should be
 // retried. Sets |override_response_headers| to redirect if so.
 bool MaybeBypassProxyAndPrepareToRetry(
+    net::ProxyService::DataReductionProxyBypassType* proxy_bypass_type,

[bengr, 2014/07/16 01:40:10]

Explain in the comment what this new paramater is and that it is allowed to be
NULL.

[megjablon, 2014/07/16 23:07:14]

Done.

     const DataReductionProxyParams* params,
     net::URLRequest* request,
     const net::HttpResponseHeaders* original_response_headers,
     scoped_refptr<net::HttpResponseHeaders>* override_response_headers);
 
 // Configure |result| to proceed directly to the origin if |result|'s current
 // proxy is the data reduction proxy, the
 // |net::LOAD_BYPASS_DATA_REDUCTION_PROXY| |load_flag| is set, and the
 // DataCompressionProxyCriticalBypass Finch trial is set.
 // This handler is intended to be invoked only by
@@ skipping 20 matching lines @@
 // maintained by the proxy service of the request. Adds
 // |data_reduction_proxies.second| to the retry list only if |bypass_all| is
 // true. Visible as part of the public API for testing.
 void MarkProxiesAsBadUntil(net::URLRequest* request,
                            base::TimeDelta& bypass_duration,
                            bool bypass_all,
                            const std::pair<GURL, GURL>& data_reduction_proxies);
 
 }  // namespace data_reduction_proxy
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PROTOCOL_H_