Issue 390373004: Pass references to SVGTextLayoutEngine::layoutTextOnLineOrPath

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390373004: Pass references to SVGTextLayoutEngine::layoutTextOnLineOrPath (Closed)

Created:
6 years, 5 months ago by fs

Modified:
6 years, 5 months ago

Reviewers:
Stephen Chennney, f(malita), pdr., kouhei (in TOK)

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Pass references to SVGTextLayoutEngine::layoutTextOnLineOrPath |text| and |style| are dereferenced in the (single) caller, so pass them as references instead of pointers. Also make the reference to the RenderSVGInlineText const, since it shouldn't be mutated in this context. This in turn requires some additional const-accessors on RenderSVGInlineText and SVGTextLayoutAttributes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178173

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	Source/core/rendering/svg/RenderSVGInlineText.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutAttributes.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutEngine.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutEngine.cpp	View	4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/390373004/1

6 years, 5 months ago (2014-07-15 12:55:06 UTC) #5

Message was sent while issue was closed.

Change committed as 178173

Expand Messages | Collapse Messages