Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 390373004: Pass references to SVGTextLayoutEngine::layoutTextOnLineOrPath (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Pass references to SVGTextLayoutEngine::layoutTextOnLineOrPath |text| and |style| are dereferenced in the (single) caller, so pass them as references instead of pointers. Also make the reference to the RenderSVGInlineText const, since it shouldn't be mutated in this context. This in turn requires some additional const-accessors on RenderSVGInlineText and SVGTextLayoutAttributes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M Source/core/rendering/svg/RenderSVGInlineText.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributes.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngine.cpp View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
Continued const-ref churn. PTAL.
6 years, 5 months ago (2014-07-15 12:34:25 UTC) #1
kouhei (in TOK)
non-owner lgtm
6 years, 5 months ago (2014-07-15 12:40:49 UTC) #2
f(malita)
lgtm
6 years, 5 months ago (2014-07-15 12:43:19 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 5 months ago (2014-07-15 12:54:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/390373004/1
6 years, 5 months ago (2014-07-15 12:55:06 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 13:24:36 UTC) #6
Message was sent while issue was closed.
Change committed as 178173

Powered by Google App Engine
This is Rietveld 408576698