Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/telemetry/telemetry/page/profile_generator.py ('K') | « tools/telemetry/telemetry/page/profile_generator.py ('k') | tools/telemetry/telemetry/results/buildbot_page_measurement_results.py » ('j') | tools/telemetry/telemetry/results/gtest_test_results_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index bbef6fb5eb8dcbd067e645c2f09e11dad3b5d127..4f9bf585c5fbb48dd872119664637ba005ae5340 100755
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -132,11 +132,11 @@ def Main(base_dir):
recorder.CustomizeBrowserOptions(options)
results = page_runner.Run(recorder, ps, expectations, options)
- if results.errors or results.failures:
+ if results.failures:
logging.warning('Some pages failed. The recording has not been updated for '
'these pages.')
logging.warning('Failed pages:\n%s', '\n'.join(
- p.display_name for p in zip(*results.errors + results.failures)[0]))
+ p.display_name for p in zip(*results.failures)[0]))
if results.skipped:
logging.warning('Some pages were skipped. The recording has not been '
« tools/telemetry/telemetry/page/profile_generator.py ('K') | « tools/telemetry/telemetry/page/profile_generator.py ('k') | tools/telemetry/telemetry/results/buildbot_page_measurement_results.py » ('j') | tools/telemetry/telemetry/results/gtest_test_results_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698