Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: tools/telemetry/telemetry/page/profile_generator.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/profile_generator.py
diff --git a/tools/telemetry/telemetry/page/profile_generator.py b/tools/telemetry/telemetry/page/profile_generator.py
index 12b6011b0c91e77c0632c62fab7f12de54f99737..1b84321f5adead9b27e92249f3d8702e0d3a9cc4 100644
--- a/tools/telemetry/telemetry/page/profile_generator.py
+++ b/tools/telemetry/telemetry/page/profile_generator.py
@@ -46,11 +46,11 @@ def GenerateProfiles(profile_creator_class, profile_creator_name, options):
results = page_runner.Run(test, test.page_set, expectations, options)
- if results.errors or results.failures:
+ if results.failures:
logging.warning('Some pages failed.')
- if results.errors or results.failures:
+ if results.failures:
Ken Russell (switch to Gerrit) 2014/07/15 00:20:20 This test is redundant. It was before, too.
chrishenry 2014/07/15 17:55:53 Done.
logging.warning('Failed pages:\n%s',
- '\n'.join(zip(*results.errors + results.failures)[0]))
+ '\n'.join(zip(*results.failures)[0]))
return 1
# Everything is a-ok, move results to final destination.

Powered by Google App Engine
This is Rietveld 408576698